Project

General

Profile

Actions

Defect #2594

closed

Authentication: Disabled identity is not checked by sso and target system authentication (disabled identity can log in over sso or target system).

Added by Radek Tomiška about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Authentication / Authorization
Target version:
Start date:
11/30/2020
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

Disabled identity is not checked in sso authentication filters (SsoIdmAuthenticationFilter) and target system authentication filters (DefaultAccAuthenticator, DefaultAccMultipleSystemAuthenticator) => valid token is created for disabled identity and identity is successfully authenticated.
Fix mentioned filters to not authenticate invalid identity.

Issue is connected to #2413, where invalid identity was checked even if token is valid (as "duplicate" check).


Related issues

Related to IdStory Identity Manager - Task #2413: Cache: add cache for tokenClosedRadek Tomiška07/31/2020

Actions
Actions #1

Updated by Radek Tomiška about 4 years ago

  • Related to Task #2413: Cache: add cache for token added
Actions #2

Updated by Radek Tomiška about 4 years ago

  • Description updated (diff)
Actions #3

Updated by Radek Tomiška about 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

Fixed together with #2506. I fixed all optional authenticators and add "duplicate" check into core authentication service again (=> not depends on custom authenticator implemation).

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/6a460fd1c3cf92319dfbe509e63418777702810b#diff-b0bc93f9c8188fc99e1d221bb11d7e020a00785eac179f9a83f4539e30539eccR49

Could you provide me a feedback, please?

Actions #4

Updated by Vít Švanda about 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did reivew and tested it against external system, thanks for this fix.

Actions #5

Updated by Radek Tomiška about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF