Project

General

Profile

Actions

Task #2413

closed

Cache: add cache for token

Added by Radek Tomiška over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Cache
Target version:
Start date:
07/31/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Token is loaded repetitivelly from DB, when expiration is not prolonged. Add cache here.


Related issues

Related to IdStory Identity Manager - Defect #2594: Authentication: Disabled identity is not checked by sso and target system authentication (disabled identity can log in over sso or target system).ClosedRadek Tomiška11/30/2020

Actions
Actions #1

Updated by Radek Tomiška over 3 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

I've added new cache for logged user tokens. I've removed redundant check for identity is disabled, when token is used => when identity is disabled (or deleted), then his tokens are disabled too (another select in each request is removed).

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/8e9ca190510cad29cdc02a6539df4dac515261ed

Could you provide me a feedback, please?

Note: All tests were speedup for 2 minutes, after cache was added.

Actions #2

Updated by Vít Švanda over 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did reivew and tested it. Thanks for this nice optimalization. LGTM

Actions #3

Updated by Radek Tomiška over 3 years ago

  • Status changed from Resolved to Closed
Actions #4

Updated by Radek Tomiška over 3 years ago

  • Related to Defect #2594: Authentication: Disabled identity is not checked by sso and target system authentication (disabled identity can log in over sso or target system). added
Actions

Also available in: Atom PDF