Project

General

Profile

Actions
Copy link

Task #2569

closed

Validation: Support BE validation in projection, show custom validation message for FE validations

Added by Alena Peterová about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Radek Tomiška
Category:
Validators
Target version:
10.7.0
Start date:
11/09/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Tested on 10.6.1 and our demo.
Even if a custom validation message is set, it's not displayed. If it is a regex, we get the general message "Form is not valid. Filled form contains invalid values."
It's on form projections and also on standard "More information" tab of a user.

Files

Download all files
validation_setting.png (11.3 KB) validation_setting.png Alena Peterová, 11/09/2020 04:46 PM
validation.png (44.2 KB) validation.png Alena Peterová, 11/09/2020 04:47 PM
form-validation.png (9.98 KB) form-validation.png Radek Tomiška, 11/10/2020 06:50 AM
validation_lownumber.png (15.1 KB) validation_lownumber.png Alena Peterová, 11/10/2020 07:34 AM
validation_number.png (4.35 KB) validation_number.png Alena Peterová, 11/10/2020 07:35 AM
Actions
Copy link
 #1

Updated by Alena Peterová about 4 years ago

  • Subject changed from Custom validation message is not displayed to Custom validation message for EAV is not displayed
  • Description updated (diff)
Actions
Copy link
 #2

Updated by Vít Švanda about 4 years ago

  • Assignee deleted (Ondřej Kopr)
  • Target version set to 10.7.0
Actions
Copy link
 #3

Updated by Radek Tomiška about 4 years ago

  • Assignee set to Radek Tomiška
Actions
Copy link
 #4

Updated by Radek Tomiška about 4 years ago

  • File form-validation.png form-validation.png added
  • Tracker changed from Defect to Task
  • Status changed from New to Needs feedback
  • Assignee changed from Radek Tomiška to Alena Peterová
  • % Done changed from 0 to 90
  • Affected versions deleted (10.2.0, 10.6.1)

Custom validation message is shown on FE in field tooltip (override default field validation message):

Note: Toast message from previous screenshot in description is returned from BE for whole form, when form is not valid (one or more form field).

Actions
Copy link
 #5

Updated by Alena Peterová about 4 years ago

You are right, I didn't notice this, sorry. However, I think there are 2 places where it could be improved:
  • attributes edited from the form projection (the validation message is not displayed and the invalid field is not highlighted at all)
  • when overriding default validation message - e.g. maximum value of a number, then the default message is displayed:

    instead of the configured custom message:
Actions
Copy link
 #6

Updated by Radek Tomiška about 4 years ago

  • Status changed from Needs feedback to New
  • Assignee changed from Alena Peterová to Radek Tomiška
  • % Done changed from 90 to 50
Actions
Copy link
 #7

Updated by Radek Tomiška about 4 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #8

Updated by Radek Tomiška about 4 years ago

  • Subject changed from Custom validation message for EAV is not displayed to Validation: Support BE validation in projection, show custom validation message for FE validations
  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 50 to 90

I've added:
- Support for BE validations into projections,
- custom validation message is used for FE validations too now.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/3108c1882debb4cbf7426ea3a5f2d71158c9df17

Could you provide me a feedback, please?

Actions
Copy link
 #9

Updated by Radek Tomiška about 4 years ago

Actions
Copy link
 #10

Updated by Vít Švanda about 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did review and tested it. Thanks for this, especially for implementation of focusing to invalid EAV attribute. It is useful in wizards too.

Actions
Copy link
 #11

Updated by Radek Tomiška about 4 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF