Feature #2568
closed
Support setting required basic attributes and validations (in form projections)
Added by Alena Peterová over 3 years ago.
Updated about 3 years ago.
Description
Form projections are awesome feature for managing e.g. externists, here are some things which could be improved for using in our projects:
- set some basic identity attribute as required, e.g. phone: we want to ensure that every externist has a phone so we can send a password to it - therefore make the "phone" required for them
- set organizational position of main contract as required: we have more organizations for externists (different for every company), so there is no default organization, but we want to make sure that the admin sets the home organization for a new externist
- unique validation will be not supported
- Subject changed from Support setting required basic attributes in form projections to Support setting required basic attributes and validations (in form projections)
- Description updated (diff)
- Target version set to 11.0.0
The same support could be added also in the standard GUI (full detail), but it's not necessary in my use case.
As discussed: please try to estimate the time to implement this feature. If it's much much more than just making a project-specific extension of the standard example projection, we should rethink to include the feature in the product. Or, maybe just add our almost-everything-required projection to the product/extras as a second standard projection.
- Priority changed from Normal to High
- Estimated time set to 48.00 h
- Status changed from New to In Progress
- Related to Feature #2699: Support setting maximal validity of a contract added
- Description updated (diff)
- Subject changed from Support setting required basic attributes and validations (in form projections) to Support setting required basic attributes and validations
- Subject changed from Support setting required basic attributes and validations to Support setting required basic attributes and validations (in form projections)
- Related to Task #2731: Eav: Support min a max validations for strings and dates added
- Related to Task #2732: Add filter for identities without projection added
- % Done changed from 0 to 80
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 80 to 90
- Status changed from Needs feedback to In Progress
- Assignee changed from Vít Švanda to Radek Tomiška
I did review and tested it. Awesome feature brings projections on new level. Good work.
Review minor notes:
- Some ENG localization is in czech ("label": "Přidat validaci",).
- UX: Although I technically understand why, it happened to me several times during testing that I forgot to save the projection. Especially for the validation detail, I subconsciously expected that after closing the detail, the record is saved. Maybe adding a warning, or saving the entire projection, could help.
- Trivial UX: If none validation is defined on projection, then is show blue info box and button for add new validation. I would expect the same behavior as when adding form definitions just below that (green button without box).
- Question: You added the method "generateNewEntity" on FE. I didn't found any implementation on the BE. Did I miss something?
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Vít Švanda
Thx for feedback!
ad localization) Fixed.
ad UX) I think so, warning should be added globally for each form, when some modification is made. Will be implemented in standalone ticket.
ad Trivial UX) I think so, it has to be the same even it was not solved by this ticket :) I added info box for form definitions.
ad Question) Good eye! Forgotten test code removed.
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/4c0bdb486291d1ff3c00d0c6d0bee4fa6b27a69e
Could you provide me a feedback again, please?
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 90 to 100
I retested it. Thanks for that.
- Status changed from Resolved to Closed
- Related to Feature #2814: Support custom label and placeholder setting for basic attributes used in form projections added
- Related to Defect #2860: Some validation errors are not localized added
Also available in: Atom
PDF
