Project

General

Profile

Actions

Feature #2568

closed

Support setting required basic attributes and validations (in form projections)

Added by Alena Peterová over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
High
Assignee:
Radek Tomiška
Category:
Frontend
Target version:
Start date:
11/09/2020
Due date:
% Done:

100%

Estimated time:
48.00 h
Owner:

Description

Form projections are awesome feature for managing e.g. externists, here are some things which could be improved for using in our projects:
  • set some basic identity attribute as required, e.g. phone: we want to ensure that every externist has a phone so we can send a password to it - therefore make the "phone" required for them
  • set organizational position of main contract as required: we have more organizations for externists (different for every company), so there is no default organization, but we want to make sure that the admin sets the home organization for a new externist
  • unique validation will be not supported

Related issues

Related to IdStory Identity Manager - Feature #2699: Support setting maximal validity of a contractClosedRadek Tomiška03/02/2021

Actions
Related to IdStory Identity Manager - Task #2731: Eav: Support min a max validations for strings and datesClosedRadek Tomiška03/25/2021

Actions
Related to IdStory Identity Manager - Task #2732: Add filter for identities without projectionClosedRadek Tomiška03/25/2021

Actions
Related to IdStory Identity Manager - Feature #2814: Support custom label and placeholder setting for basic attributes used in form projectionsClosedRadek Tomiška05/17/2021

Actions
Related to IdStory Identity Manager - Defect #2860: Some validation errors are not localizedClosedRadek Tomiška06/18/2021

Actions
Actions #1

Updated by Alena Peterová about 3 years ago

  • Subject changed from Support setting required basic attributes in form projections to Support setting required basic attributes and validations (in form projections)
  • Description updated (diff)
  • Target version set to 11.0.0

The same support could be added also in the standard GUI (full detail), but it's not necessary in my use case.

As discussed: please try to estimate the time to implement this feature. If it's much much more than just making a project-specific extension of the standard example projection, we should rethink to include the feature in the product. Or, maybe just add our almost-everything-required projection to the product/extras as a second standard projection.

Actions #2

Updated by Alena Peterová about 3 years ago

  • Priority changed from Normal to High
Actions #3

Updated by Radek Tomiška about 3 years ago

  • Estimated time set to 48.00 h
Actions #4

Updated by Radek Tomiška about 3 years ago

  • Status changed from New to In Progress
Actions #5

Updated by Radek Tomiška about 3 years ago

  • Related to Feature #2699: Support setting maximal validity of a contract added
Actions #6

Updated by Radek Tomiška about 3 years ago

  • Description updated (diff)
Actions #7

Updated by Radek Tomiška about 3 years ago

  • Subject changed from Support setting required basic attributes and validations (in form projections) to Support setting required basic attributes and validations
Actions #8

Updated by Radek Tomiška about 3 years ago

  • Subject changed from Support setting required basic attributes and validations to Support setting required basic attributes and validations (in form projections)
Actions #9

Updated by Radek Tomiška about 3 years ago

  • Related to Task #2731: Eav: Support min a max validations for strings and dates added
Actions #10

Updated by Radek Tomiška about 3 years ago

  • Related to Task #2732: Add filter for identities without projection added
Actions #12

Updated by Radek Tomiška about 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 80 to 90
Actions #13

Updated by Vít Švanda about 3 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Radek Tomiška

I did review and tested it. Awesome feature brings projections on new level. Good work.

Review minor notes:
  • Some ENG localization is in czech ("label": "Přidat validaci",).
  • UX: Although I technically understand why, it happened to me several times during testing that I forgot to save the projection. Especially for the validation detail, I subconsciously expected that after closing the detail, the record is saved. Maybe adding a warning, or saving the entire projection, could help.
  • Trivial UX: If none validation is defined on projection, then is show blue info box and button for add new validation. I would expect the same behavior as when adding form definitions just below that (green button without box).
  • Question: You added the method "generateNewEntity" on FE. I didn't found any implementation on the BE. Did I miss something?
Actions #14

Updated by Radek Tomiška about 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda

Thx for feedback!

ad localization) Fixed.
ad UX) I think so, warning should be added globally for each form, when some modification is made. Will be implemented in standalone ticket.
ad Trivial UX) I think so, it has to be the same even it was not solved by this ticket :) I added info box for form definitions.
ad Question) Good eye! Forgotten test code removed.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/4c0bdb486291d1ff3c00d0c6d0bee4fa6b27a69e

Could you provide me a feedback again, please?

Actions #15

Updated by Vít Švanda about 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I retested it. Thanks for that.

Actions #16

Updated by Radek Tomiška almost 3 years ago

  • Status changed from Resolved to Closed
Actions #17

Updated by Radek Tomiška almost 3 years ago

  • Related to Feature #2814: Support custom label and placeholder setting for basic attributes used in form projections added
Actions #18

Updated by Radek Tomiška almost 3 years ago

  • Related to Defect #2860: Some validation errors are not localized added
Actions

Also available in: Atom PDF