IdStory IdM modules » extras

The implementation is in branch https://github.com/bcvsolutions/czechidm-extras/tree/2421-implement-general-parser which was based on 2.5.0-RC and rkubica/2329-ImportCSVUserContractRolesTaskExecutor to make sure I have the current code for all import tasks since the refactoring was quite major.

1. created AbstractCsvImportTask.java and AbstractCsvImportTaskTest.java as the classes from which every import task and its test inherits
2. I deprecated ImportAutomaticRoleAttributesFromCSVExecutor.java since it is replaced by ImportAutomaticRoleByAttributesCSVExecutor.java which is much more useful. Some clients might use it so I don't want to remove it completely just yet. But this is up to you.
3. I refactored every other import task to use the new code but functionality did not change except for a few LRTs (see below). I added localization to every task, though, because AbstractCsvImportTask.java excepts to use it.
4. I refactored ImportRolesFromCSVExecutor.java to use the dynamic columns approach with prefixes for system and EAV attributes.
5. I refactored ImportCSVUserContractRolesTaskExecutor.java to allow using more than one contract EAV to find the contract to which roles are added.

All tests passed. Documentation was updated.

@sourek, can you please give me feedback?

Hi, thanks for the refactoring. It finally looks nice. I have not found any major issue, just a few cosmetics:

• try not to nest try-catch blocks (AbstractCsvImportTask) - either merge try blocks (add second catch block), or extract nested try-catch to separate method
• ImportCSVUserContractRolesTaskExecutor#handleRecords needs to be refactored
• ImportCSVUserContractRolesTaskExecutor:401 Use CONTRACT_DEFINITION inbstead of string default
• ImportCSVUserContractRolesTaskExecutor:299 no need to pass definition to message if its null
• Error in tests:
  

   [ERROR] Failures: 
   [ERROR]   ImportCSVUserContractRolesTaskExecutorTest.assignRolesToAllContractTest:184->AbstractCsvImportTaskTest.createAttachment:109
   [ERROR]   ImportCSVUserContractRolesTaskExecutorTest.assignRolesToPrimeContractTest:116->AbstractCsvImportTaskTest.createAttachment:109
  

• ImportAutomaticRoleAttributesFromCSVExecutor is not deprecated - and please add this information to locales so that it is visible in UI
• Few sonar errors here and there

Thanks for fixes. It looks great.