Task #2341
closed
Evaluator for IdmIdentity and IdmIdentityContract : Subordinate with given projection
Added by Peter Štrunc almost 4 years ago.
Updated almost 4 years ago.
Description
Goal of this ticket is to create two evalutors which will filter results by these criteria:
Identity/contract is subordinate of curretly logged user
Identity/contracts owner has given projection
both of these criteria must be satisfied in order to gain acces to said objects.
- Status changed from In Progress to Needs feedback
- Assignee changed from Peter Štrunc to Radek Tomiška
- % Done changed from 0 to 70
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Peter Štrunc
I did test and code review, it works and reusing of exist evaluators from product is nice.
Review notes:
- Module cannot be compiled - some foreign import "com.sun.tools.doclint.Entity" is forgotten in IdentitySubordinateWithProjectionEvaluatorTest :(
- IdentitySubordinateWithProjectionEvaluatorTest, ContractSubordinateWithProjectionEvaluatorTest - hard coded codes can be replaced with getHelper().createName() => this is the reason, why IdentitySubordinateWithProjectionEvaluatorTest fails !!!
- localization for newly added evaluator is missing.
- IdentitySubordinateWithProjectionEvaluator, ContractSubordinateWithProjectionEvaluator - method getPermission is not tested.
- a lot warning is in code (unused imports, unchecked ...) and javadoc (author...) is missing ...
- IdentitySubordinateWithProjectionEvaluator - permission1 and permission2 could have better names.
- add please link to branch on github for review next time - a lot of branches is in extras repository :)
Review notes (not related to this feature):
- old and released module version 2.3.0 is forgotten in your develop branch
- contractEndInFuture, contractEndNow is not valid by xsd schema (code should be the first element)
- Status changed from In Progress to Closed
- % Done changed from 70 to 100
ASll of the above issues were resolved. Merged to develop.
Also available in: Atom
PDF
