Project

General

Profile

Actions
Copy link

Task #2341

closed

Evaluator for IdmIdentity and IdmIdentityContract : Subordinate with given projection

Added by Peter Štrunc over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Štrunc
Target version:
2.4.0
Start date:
06/22/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Goal of this ticket is to create two evalutors which will filter results by these criteria:

Identity/contract is subordinate of curretly logged user
Identity/contracts owner has given projection

both of these criteria must be satisfied in order to gain acces to said objects.

Actions
Copy link
 #1

Updated by Peter Štrunc over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Peter Štrunc to Radek Tomiška
  • % Done changed from 0 to 70

Implemented in pstrunc/2341-subordinate-evaluator
Documentation is here: https://wiki.czechidm.com/devel/documentation/modules_extras/subordinate_projection_evaluators

@tomiskar would you please review this ticket? Thank you

Actions
Copy link
 #2

Updated by Radek Tomiška over 4 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Peter Štrunc

I did test and code review, it works and reusing of exist evaluators from product is nice.

Review notes:
- Module cannot be compiled - some foreign import "com.sun.tools.doclint.Entity" is forgotten in IdentitySubordinateWithProjectionEvaluatorTest :(
- IdentitySubordinateWithProjectionEvaluatorTest, ContractSubordinateWithProjectionEvaluatorTest - hard coded codes can be replaced with getHelper().createName() => this is the reason, why IdentitySubordinateWithProjectionEvaluatorTest fails !!!
- localization for newly added evaluator is missing.
- IdentitySubordinateWithProjectionEvaluator, ContractSubordinateWithProjectionEvaluator - method getPermission is not tested.
- a lot warning is in code (unused imports, unchecked ...) and javadoc (author...) is missing ...
- IdentitySubordinateWithProjectionEvaluator - permission1 and permission2 could have better names.
- add please link to branch on github for review next time - a lot of branches is in extras repository :)

Review notes (not related to this feature):
- old and released module version 2.3.0 is forgotten in your develop branch
- contractEndInFuture, contractEndNow is not valid by xsd schema (code should be the first element)

Actions
Copy link
 #3

Updated by Peter Štrunc over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 70 to 100

ASll of the above issues were resolved. Merged to develop.

Actions
Copy link

Also available in: Atom PDF