Task #2329
closed
Support multivalued role column in ImportCSVUserContractRolesTaskExecutor
Added by Marek Klement almost 4 years ago.
Updated over 3 years ago.
Description
Task ImportCSVUserContractRolesTaskExecutor should be changed. There are some issues:
- Column with roles is not multivalued as name insist
- When a role is assigned to all contracts of the user, values of the EAV column have to be empty - use boolean instead
- Use only for the main contract - add boolean property
- At line 138 there is used isEmpty method - better use StringUtils.isBlank()
- Default definition of eav is used - maybe in configuration add a property with the name of the definition
- Description updated (diff)
- Related to Defect #2323: ImportCSVUserContractRolesTaskExecutor - Contract EAV is null instead of empty String added
- Assignee changed from Marek Klement to Roman Kubica
- Status changed from New to In Progress
- % Done changed from 0 to 60
- Status changed from In Progress to Needs feedback
- Assignee changed from Roman Kubica to Peter Štrunc
- Target version set to 2.5.0
- % Done changed from 60 to 70
- Status changed from Needs feedback to In Progress
- Assignee changed from Peter Štrunc to Roman Kubica
Thanks for the changes. It looks great. I have found few minor issues.
Please document in more detail what each type of role assignment (allContracts, primeContract or eavContract) does.
replace "eu.bcvsolutions.idm.core.model.entity.IdmIdentityContract" with IdmIdentityContract.class.getName()
There are few places with commmented unnecessary code. Please delete them.
I am postponing this feature to 2.6.0
- Target version changed from 2.5.0 to 2.6.0
- Assignee changed from Roman Kubica to Peter Štrunc
- % Done changed from 70 to 90
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
Looks great. Thanks. I merged it to develop.
Also available in: Atom
PDF
