Project

General

Profile

Actions
Copy link

Task #2329

closed

Support multivalued role column in ImportCSVUserContractRolesTaskExecutor

Added by Marek Klement over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Štrunc
Target version:
2.6.0
Start date:
06/17/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Task ImportCSVUserContractRolesTaskExecutor should be changed. There are some issues:
  • Column with roles is not multivalued as name insist
  • When a role is assigned to all contracts of the user, values of the EAV column have to be empty - use boolean instead
  • Use only for the main contract - add boolean property
  • At line 138 there is used isEmpty method - better use StringUtils.isBlank()
  • Default definition of eav is used - maybe in configuration add a property with the name of the definition

Related issues

Related to extras - Defect #2323: ImportCSVUserContractRolesTaskExecutor - Contract EAV is null instead of empty StringNew06/12/2020

Actions
Actions
Copy link
 #1

Updated by Marek Klement over 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Marek Klement over 4 years ago

  • Related to Defect #2323: ImportCSVUserContractRolesTaskExecutor - Contract EAV is null instead of empty String added
Actions
Copy link
 #3

Updated by Marek Klement over 4 years ago

  • Assignee changed from Marek Klement to Roman Kubica
Actions
Copy link
 #4

Updated by Roman Kubica over 4 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 60
Actions
Copy link
 #5

Updated by Roman Kubica over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Roman Kubica to Peter Štrunc
Actions
Copy link
 #7

Updated by Roman Kubica over 4 years ago

  • Target version set to 2.5.0
Actions
Copy link
 #8

Updated by Roman Kubica over 4 years ago

  • % Done changed from 60 to 70
Actions
Copy link
 #9

Updated by Peter Štrunc over 4 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Peter Štrunc to Roman Kubica

Thanks for the changes. It looks great. I have found few minor issues.

Please document in more detail what each type of role assignment (allContracts, primeContract or eavContract) does.
replace "eu.bcvsolutions.idm.core.model.entity.IdmIdentityContract" with IdmIdentityContract.class.getName()
There are few places with commmented unnecessary code. Please delete them.

I am postponing this feature to 2.6.0

Actions
Copy link
 #10

Updated by Peter Štrunc over 4 years ago

  • Target version changed from 2.5.0 to 2.6.0
Actions
Copy link
 #12

Updated by Peter Štrunc over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

Looks great. Thanks. I merged it to develop.

Actions
Copy link

Also available in: Atom PDF