Task #2316
closed
Import LRT for code list
Added by Roman Kučera over 4 years ago. Updated over 4 years ago.
100%
Description
We will create LRT for importing code list and it's values from csv.
In LRT you can configure:
- code of code list
- name of code list
- description of code list
- seperator
CSV structure for items
key;value
Related issues
Updated by Roman Kučera over 4 years ago
- % Done changed from 0 to 50
Implementation in https://github.com/bcvsolutions/czechidm-extras/tree/2316-code-list-import-lrt
TODO- documentation
- tests
- test it manually in IdM
Updated by Roman Kučera over 4 years ago
- Target version changed from 2.4.0 to 1.9.0
Updated by Roman Kučera over 4 years ago
- % Done changed from 50 to 90
Tests implemented.
Manually tested
Documentation https://wiki.czechidm.com/devel/documentation/modules_extras#import_code_list_and_it_s_items
https://wiki.czechidm.com/devel/documentation/modules_extras/import_code_list_an_it_s_items
Updated by Peter Štrunc over 4 years ago
- Copied to Task #2318: Import LRT for code list added
Updated by Roman Kučera over 4 years ago
Fixed closing of streams. Thx Radek for this note.
Updated by Roman Kučera over 4 years ago
Added option for importing EAV to code list item.
Updated by Roman Kučera over 4 years ago
Implemented tests for new code for EAV import
Updated by Roman Kučera over 4 years ago
- Target version changed from 1.9.0 to 2.5.0
Updated by Ondřej Kopr over 4 years ago
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
- when task catch error/s, the error is just logged with log4j - please return operationResult - failed,
- for success imports return operationResult - success (now is there null),
- if you have some time please add localization for the task.
Otherwise task works, thank you for the feature.
Updated by Roman Kučera over 4 years ago
- Status changed from Resolved to In Progress
- % Done changed from 100 to 90
Thx, I fixed it here
https://github.com/bcvsolutions/czechidm-extras/commit/57e7446e4c5a289f3d6593f81fe3e3b36fefb980
https://github.com/bcvsolutions/czechidm-extras/commit/bdb578ac1bc2c555422763a45c67f037d08530d9
Right now I am doing some more refactoring based on our internal discussion. Some abstract LRT class will used
Updated by Peter Štrunc over 4 years ago
- Target version changed from 2.5.0 to 2.6.0
I am moving this feature to 2.6.0 until the refactoring is done
Updated by Peter Štrunc over 4 years ago
Hey @kucerar,
how is it going with the refactoring? Could you please look at this merge request https://github.com/bcvsolutions/czechidm-extras/pull/38 and confirm that it contains everything needed?
Thanks
Updated by Roman Kučera over 4 years ago
@sourek I checked the MR a it looks good to me, all commits should be there.
After you merge it into develop, I will just test the LRT quickly to see if everything works correctly, because @doischert makes some changes in the abstract class.
Updated by Roman Kučera over 4 years ago
I retest it under develop branch. It works correctly.
Updated by Peter Štrunc over 4 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100