Project

General

Profile

Actions
Copy link

Task #2316

closed

Import LRT for code list

Added by Roman Kučera over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Roman Kučera
Target version:
2.6.0
Start date:
06/10/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Now you have no option how to import code list and it's items.
We will create LRT for importing code list and it's values from csv.
In LRT you can configure:
  • code of code list
  • name of code list
  • description of code list
  • seperator

CSV structure for items
key;value

Related issues

Copied to extras - Task #2318: Import LRT for code listClosedRoman Kučera06/10/2020

Actions
Actions
Copy link
 #1

Updated by Roman Kučera over 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Roman Kučera over 4 years ago

  • % Done changed from 0 to 50

Implementation in https://github.com/bcvsolutions/czechidm-extras/tree/2316-code-list-import-lrt

TODO
  • documentation
  • tests
  • test it manually in IdM
Actions
Copy link
 #3

Updated by Roman Kučera over 4 years ago

  • Target version changed from 2.4.0 to 1.9.0
Actions
Copy link
 #5

Updated by Peter Štrunc over 4 years ago

  • Copied to Task #2318: Import LRT for code list added
Actions
Copy link
 #6

Updated by Roman Kučera over 4 years ago

Fixed closing of streams. Thx Radek for this note.

Actions
Copy link
 #7

Updated by Roman Kučera over 4 years ago

Added option for importing EAV to code list item.

Actions
Copy link
 #8

Updated by Roman Kučera over 4 years ago

Implemented tests for new code for EAV import

Actions
Copy link
 #9

Updated by Roman Kučera over 4 years ago

  • Target version changed from 1.9.0 to 2.5.0
Actions
Copy link
 #10

Updated by Ondřej Kopr over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100
I made review and tests. Whole behavior works well! I just found these little UX things:
  • when task catch error/s, the error is just logged with log4j - please return operationResult - failed,
  • for success imports return operationResult - success (now is there null),
  • if you have some time please add localization for the task.

Otherwise task works, thank you for the feature.

Actions
Copy link
 #11

Updated by Roman Kučera over 4 years ago

  • Status changed from Resolved to In Progress
  • % Done changed from 100 to 90

Thx, I fixed it here
https://github.com/bcvsolutions/czechidm-extras/commit/57e7446e4c5a289f3d6593f81fe3e3b36fefb980
https://github.com/bcvsolutions/czechidm-extras/commit/bdb578ac1bc2c555422763a45c67f037d08530d9

Right now I am doing some more refactoring based on our internal discussion. Some abstract LRT class will used

Actions
Copy link
 #12

Updated by Peter Štrunc over 4 years ago

  • Target version changed from 2.5.0 to 2.6.0

I am moving this feature to 2.6.0 until the refactoring is done

Actions
Copy link
 #13

Updated by Peter Štrunc over 4 years ago

Hey @kucerar,
how is it going with the refactoring? Could you please look at this merge request https://github.com/bcvsolutions/czechidm-extras/pull/38 and confirm that it contains everything needed?

Thanks

Actions
Copy link
 #14

Updated by Roman Kučera over 4 years ago

@sourek I checked the MR a it looks good to me, all commits should be there.
After you merge it into develop, I will just test the LRT quickly to see if everything works correctly, because @doischert makes some changes in the abstract class.

Actions
Copy link
 #15

Updated by Roman Kučera over 4 years ago

I retest it under develop branch. It works correctly.

Actions
Copy link
 #16

Updated by Peter Štrunc over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100
Actions
Copy link

Also available in: Atom PDF