Task #2258
closed
Implement support for sync of role-catalogue
Added by Vít Švanda over 4 years ago. Updated about 4 years ago.
100%
Related issues
Updated by Vít Švanda over 4 years ago
- Target version changed from 10.4.0 to 10.6.0
Updated by Radek Tomiška about 4 years ago
- Related to Task #520: Support synchronization of role catalogs added
Updated by Ondrej Husník about 4 years ago
- Assignee changed from Ondrej Husník to Vít Švanda
- % Done changed from 70 to 90
I implemented role catalogue synchronization. It originates from general tree node synchronization.
Please could you provide me a feedback?
https://github.com/bcvsolutions/CzechIdMng/commit/9291e72987b623a7e35f187b4cae7bb4dea9dccd
https://wiki.czechidm.com/devel/documentation/synchronization/dev/role-catalogue-sync
Updated by Vít Švanda about 4 years ago
- Status changed from In Progress to Needs feedback
Updated by Vít Švanda about 4 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Vít Švanda to Ondrej Husník
I did reivew and tested it. Works nice. Thanks for that.
I found some minor issues:
- TreeResultsHandler is the inner class wich is same in the Tree and RoleCatalogue executer. Should be reused/extracted.
- Variables 'treeNode' should be renamed.
- URL to a role catalog sync documentation missing in the table (https://wiki.czechidm.com/devel/documentation/synchronization/dev/synchronization#entities_that_supports_sync).
Updated by Ondrej Husník about 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Vít Švanda
Thank you for your review. According your findings I added missing reference to documentation and changed variable name in order to better fit the content. I also extracted the TreeResultsHandler class into individual file.
Please check my changes again.
https://github.com/bcvsolutions/CzechIdMng/commit/f6197f9b86020b4e83b36884c2b4a3efd46f085d
https://wiki.czechidm.com/devel/documentation/synchronization/dev/synchronization#entities_that_supports_sync
Updated by Vít Švanda about 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Ondrej Husník
- % Done changed from 90 to 100
I did rereview. LGTM
Updated by Radek Tomiška about 4 years ago
- Status changed from Resolved to Closed