Defect #219
closed
EnumSelecBox duplicity options
Added by Ondřej Kopr about 8 years ago.
Updated over 5 years ago.
Description
- Fix fill options values into enumSelectBox (found where is mistake),
- add complete test for this component.
- Status changed from New to In Progress
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 0 to 90
Found problem:
- valueKey in component EnumSelectBox was ITEM_FULL_KEY, but this key isn't in enum class,
- was added ITEM_VALUE whitch is unique,
- tested on change password form and roles detail.
EDIT:
- after create test i was edit my solutions, because ITEM_FULL_KEY is necessary for identification options.
Test for this component.
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
After some consultation with RT.
- EnumSelectBox now using Select.Async, this is unnecessarily. Create task for simplification this component, #229
- for now create next if else statement block with enumeration.
To method itemRenderer add if statement when exists niceLabel then dont change it.
Please do test:
- On role detail found <Basic.EnumSelectBox> line 149, remove readOnly={!Utils.Entity.isNew(entity)} and add multiSelect, then test on role detail.
Thank you.
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
Add temporary solution, change valueKey from ITEM_FULL_KEY to ITEM_VALUE.
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
- Tracker changed from Task to Defect
- Category changed from 20 to Frontend
Also available in: Atom
PDF
