Project

General

Profile

Actions

Task #2180

closed

Allow user to set encoding for ImportRolesFromCSVExecutor and ImportAutomaticRoleAttributesFromCSVExecutor

Added by Peter Štrunc over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Štrunc
Target version:
Start date:
04/01/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

The goal of this ticket is to enable user to specify charset for these two LRT tasks.


Related issues

Copied to extras - Task #2267: Allow user to set encoding for ImportRolesFromCSVExecutor and ImportAutomaticRoleAttributesFromCSVExecutorClosedPeter Štrunc04/01/2020

Actions
Actions #1

Updated by Peter Štrunc over 4 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Peter Štrunc to Marek Klement
  • % Done changed from 0 to 80

Implementation is in branch 1.7.1-RC @klementm would you please review this ticket?

Actions #2

Updated by Marek Klement over 4 years ago

  • Status changed from Needs feedback to In Progress
  • % Done changed from 80 to 90
Looks great, just two minor things:
  • There are few unused imports in code in classes - ImportAutomaticRoleAttributesFromCSVExecutorTest, ImportRolesFromCSVExecutor
  • Ad this option to tutorials for these LRTs

Otherwise, review OK, thanks

Actions #3

Updated by Marek Klement over 4 years ago

  • Assignee changed from Marek Klement to Peter Štrunc
Actions #4

Updated by Peter Štrunc over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

Fixed. CLosing ticket

Actions #5

Updated by Tomáš Doischer over 4 years ago

Can you please update the tutorials as well? I can't seem to find any mention of it there.

Actions #6

Updated by Peter Štrunc over 4 years ago

  • Copied to Task #2267: Allow user to set encoding for ImportRolesFromCSVExecutor and ImportAutomaticRoleAttributesFromCSVExecutor added
Actions #7

Updated by Peter Štrunc over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF