Task #1993
closed
Fix a bug in ImportAutomaticRoleForTreeNodeFromCSVExecutor
Added by Tomáš Doischer about 5 years ago.
Updated almost 5 years ago.
Description
There is a bug in ImportAutomaticRoleForTreeNodeFromCSVExecutor when a tree node does not exist, the whole thing fails.
- Status changed from In Progress to Needs feedback
- % Done changed from 0 to 70
- Assignee changed from Tomáš Doischer to Peter Štrunc
@sourek, can you please review the code? Thank you.
- Status changed from Needs feedback to In Progress
- Assignee changed from Peter Štrunc to Tomáš Doischer
Code looks good. Please create a test, that would check that your fix really works.
- Status changed from In Progress to Needs feedback
- Assignee changed from Tomáš Doischer to Peter Štrunc
Thanks, I changed the csv file to contain a non-existent tree node and role and check in the test that two item were logged as not executed which should work as a test that the fix and the improvement in logging processed items work.
- Status changed from Needs feedback to Closed
- % Done changed from 70 to 100
Thanks it looks good. I merged it to develop.
Also available in: Atom
PDF
