Project

General

Profile

Actions
Copy link

Task #1993

closed

Fix a bug in ImportAutomaticRoleForTreeNodeFromCSVExecutor

Added by Tomáš Doischer about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Štrunc
Target version:
1.5.0
Start date:
12/11/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

There is a bug in ImportAutomaticRoleForTreeNodeFromCSVExecutor when a tree node does not exist, the whole thing fails.

Actions
Copy link
 #1

Updated by Tomáš Doischer about 5 years ago

  • Status changed from In Progress to Needs feedback
  • % Done changed from 0 to 70

I fixed the bug and also added a better logging, the LRT now shows processed items.

The code is in this branch: https://github.com/bcvsolutions/czechidm-extras/compare/1993-tdoischer-fix-ImportAutomaticRoleForTreeNodeFromCSVExecutor?expand=1

All tests run fine.

Actions
Copy link
 #2

Updated by Tomáš Doischer about 5 years ago

  • Assignee changed from Tomáš Doischer to Peter Štrunc

@sourek, can you please review the code? Thank you.

Actions
Copy link
 #3

Updated by Peter Štrunc about 5 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Peter Štrunc to Tomáš Doischer

Code looks good. Please create a test, that would check that your fix really works.

Actions
Copy link
 #4

Updated by Tomáš Doischer about 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Tomáš Doischer to Peter Štrunc

Thanks, I changed the csv file to contain a non-existent tree node and role and check in the test that two item were logged as not executed which should work as a test that the fix and the improvement in logging processed items work.

Actions
Copy link
 #5

Updated by Peter Štrunc almost 5 years ago

  • Status changed from Needs feedback to Closed
  • % Done changed from 70 to 100

Thanks it looks good. I merged it to develop.

Actions
Copy link

Also available in: Atom PDF