Project

General

Profile

Actions

Defect #1947

closed

Filter doesn't keep values after filter was executed

Added by Vít Švanda over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Frontend
Target version:
Start date:
11/19/2019
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

Affected version 10.0.0-SNAPSHOT


Related issues

Related to IdStory Identity Manager - Defect #1921: Tree node detail: show insufficient permissions warningClosedRadek Tomiška11/05/2019

Actions
Actions #1

Updated by Vít Švanda over 4 years ago

  • Tracker changed from Task to Defect
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 0 to 50

I fixed this problem. All filters works now.

Problem was in Basic.Div component. That component render children on two places. First wrapped in the Loading component. Second render directly (without wrapping). That is cause of problem, because when filter is executed the showloading is sets and children are rendered wrapped in Loading component -> old children (AbstractFrom with filter) is unmonted and local data missed.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/29e3a682ea6abc1aa50a2f59eae82530e45fa8cf

I modified Basic.Div component for using only one render of children. That created UI problems with a styling of component (RoleSelect) and that must be fixed yet.

Radek, please try to fix this.

Actions #2

Updated by Radek Tomiška over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 50 to 90

I did test and code review of your changes, filters keep values properly, thx!

I fixed issue with Basic.Div - div props are simply moved into Basic.Loading :)

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/287134118fd141961f7d1fef23f71b217ccb32e8

I fixed some FE issues:
- refresh organization tree => blank page was shown (the same as #1921 - check null pointer added, will be fixed in LTS too)
- copy assigned roles by other user => blank page was shown => added timeout
- role select - roles cannot be selected => i had to create new arrays instances (render not occurs, because arrays in component state has the same reference).

Could you do a feedback, please?

Actions #3

Updated by Radek Tomiška over 4 years ago

  • Related to Defect #1921: Tree node detail: show insufficient permissions warning added
Actions #4

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did review and test. Thanks for a fixies.

Actions #5

Updated by Vít Švanda over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF