Project

General

Profile

Actions

Defect #1921

closed

Tree node detail: show insufficient permissions warning

Added by Radek Tomiška over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Radek Tomiška
Category:
Tree structures
Target version:
Start date:
11/05/2019
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

When tree node detail is shown, and currently logged use has not permission to read this tree node, then empty page is shown => add appropriate warning message about insufficient permissions.


Related issues

Related to IdStory Identity Manager - Defect #1947: Filter doesn't keep values after filter was executedClosedRadek Tomiška11/19/2019

Actions
Actions #1

Updated by Radek Tomiška over 4 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • Target version set to Rhyolite (9.7.12)
  • % Done changed from 0 to 90

It's fixed, detail button is shown, if read tree node detail permission is granted.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/02feaabdc833a8e39bffd069147b5cd31e252e80

Could you do a feedback, please?

Actions #2

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Radek Tomiška

I did review and test and permission on read works correctly now (I don't see the button for show detail of node now).

I checked a JavaScript console and there occurrs exception on every tree refresh.
The exception doesn't have impact, but is not nice.
Cause of this exception is method "NodeTable._useFilterByTree", where nodeId is required, but this method is call without this parameter. This is strang and I am not sure what shoud be correct behavior here.
Can you check this code please?

Interesting thing is "ŕendered" on row 230 :-) .

Uncaught Error: Queued actions must have a <id> property
Actions #3

Updated by Radek Tomiška over 4 years ago

  • Related to Defect #1947: Filter doesn't keep values after filter was executed added
Actions #4

Updated by Radek Tomiška over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda

Thanks for feedback, i definitely broke it with this change. It's fixed:
https://github.com/bcvsolutions/CzechIdMng/commit/f0a5db6d6a155a3fdc724061154a029057f9d4a4#diff-f3a8e23e9ccec4b5274f5653a11a36f3

Could you please do a feedback, again :) ?

Actions #5

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

Works and no exception is occur now. Thanks for that.

Actions #6

Updated by Radek Tomiška over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF