Project

General

Profile

Actions

Defect #1830

closed

Disable/enable public password reset configuration doesn't work

Added by Ondřej Kopr over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
High
Assignee:
Patrik Stloukal
Target version:
Start date:
09/02/2019
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

Please check changes that is done in ticket #962 commit: https://git.bcvsolutions.eu/modules/password-reset/commit/587e121d2f622590bdc54fdf7434f43c84676a45

In this ticket was changed configuration property "idm.pub.pwdreset.identity.passwordReset.public.idm.enabled" with pwdResetConfiguration.isPwdResetIdmEnabled(). But method in this configuration service contains behavior:

return moduleService.isEnabled(PwdResetModuleDescriptor.MODULE_ID);

So after this changes doesn't work feature with enable disable password reset. This is probably big issue for project that has version 1.5.0 because password reset will even configuration for reset is disabled. Tests for this case probably missing.

Actions #1

Updated by Patrik Stloukal over 4 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Patrik Stloukal to Ondřej Kopr
  • % Done changed from 0 to 90

ok, i made change of this property.
I tested situation before and after fix and now it should be working properly.

commit: https://git.bcvsolutions.eu/modules/password-reset/commits/pstloukal/1830-enable-disable-idm-reset-pwd

Can you check it again and write feedback? thx.

Actions #2

Updated by Ondřej Kopr over 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondřej Kopr to Patrik Stloukal
  • % Done changed from 90 to 100

We made feedback. It's work correctly good job!

Actions #3

Updated by Ondřej Kopr over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF