Task #962
closed
Create PwdResetConfiguration
100%
Description
Create class PwdResetConfiguration and move all module properties (e.g. verification.ttl, allowed.attrs, passwordReset.public.idm.enabled) into it. See IdentityConfiguration for inspiration.
Related issues
Updated by Radek Tomiška almost 7 years ago
- Precedes Task #955: Disable password reset in IdM added
Updated by Patrik Stloukal almost 7 years ago
- Status changed from New to Needs feedback
- Assignee changed from Patrik Stloukal to Radek Tomiška
- % Done changed from 0 to 90
i created interface PwdResetConfiguration and class DefaultPwdResetConfiguration like IdentityConfiguration
commit: https://git.bcvsolutions.eu/modules/password-reset/commit/282253ac798745b89022ce3f9604e21c18430ef4
please look on my implementation and write feedback.
Updated by Radek Tomiška over 6 years ago
- Assignee changed from Radek Tomiška to Peter Štrunc
Updated by Peter Štrunc over 6 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Peter Štrunc to Patrik Stloukal
I did review. Why is new configuration not used anywhere?
Updated by Patrik Stloukal over 6 years ago
- Assignee changed from Patrik Stloukal to Peter Štrunc
i don't know now, maybe it is not in ticket description or maybe i wanted to be sure it is correctly implemented...
so i use them in code, but property "pwdreset.token.ttl" (as is in documentation) is nowhere used - but property "pwdreset.verification.ttl". I think it is the same property so i replace it..
commit: https://git.bcvsolutions.eu/modules/password-reset/commit/587e121d2f622590bdc54fdf7434f43c84676a45
https://git.bcvsolutions.eu/modules/password-reset/commit/219867f016be308ca127246176f594d8a33e2838
Updated by Patrik Stloukal over 6 years ago
i forgot about tests
commit: https://git.bcvsolutions.eu/modules/password-reset/commit/fbbe41df7ebcef157687acff1b0e3341aa256b07
Updated by Peter Štrunc over 6 years ago
- Assignee changed from Peter Štrunc to Patrik Stloukal
Please check if you can refactor PasswordResetRequestCreationProcessor to also use newly created config. Thanks
Updated by Patrik Stloukal over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Patrik Stloukal to Peter Štrunc
i added two properties to pwdconfiguration and used them in PasswordResetRequestCreationProcessor.
commit: https://git.bcvsolutions.eu/modules/password-reset/commit/91a310e2236e0f35b14d0c627216b63b5e9be628
Updated by Peter Štrunc over 6 years ago
- Status changed from Needs feedback to Closed
- % Done changed from 90 to 100
Ok. Merged to dev. Closing