Task #1751
closed
Display/download and edit workflow source
Added by Alena Peterová over 5 years ago. Updated over 5 years ago.
100%
Description
Version 9.6
There is no way in GUI to display the source of deployed workflows. So we can't check if it's correctly deployed.
Please add some way to display or download (or both) the current workflow definition.
And please add some easy way to edit the workflow in GUI.
Updated by Alena Peterová over 5 years ago
- Subject changed from Display/download workflow source to Display/download and update workflow source
- Description updated (diff)
Updated by Alena Peterová over 5 years ago
- Subject changed from Display/download and update workflow source to Display/download and edit workflow source
Updated by Vít Švanda over 5 years ago
- Target version deleted (
Rhyolite (9.7.3))
Are you sure "And please add some easy way to edit the workflow in GUI."? This is a little different requirements than on the begin and much more harder. So I have to move this feature from next version.
Updated by Alena Peterová over 5 years ago
Vít Švanda wrote:
Are you sure "And please add some easy way to edit the workflow in GUI."? This is a little different requirements than on the begin and much more harder. So I have to move this feature from next version.
I didn't know that. If displaying is easy and editing hard, then please split it into two features. Displaying/downloading would really help us. Editing is then nice to have (I can download it, edit it locally, upload).
Updated by Vít Švanda over 5 years ago
For add, download, edit an activiti workflow in browser, you can use the Activiti explorer. It can works on the same DB as IdM.
Updated by Vít Švanda over 5 years ago
- Assignee changed from Vít Švanda to Artem Kolychev
- Target version set to Rhyolite (9.7.3)
- Estimated time set to 16.00 h
In this ticket is now target add the support for download latest version of process definition (xml).
Updated by Artem Kolychev over 5 years ago
- Status changed from New to In Progress
Updated by Artem Kolychev over 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Artem Kolychev to Vít Švanda
Updated by Vít Švanda over 5 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Vít Švanda to Artem Kolychev
- % Done changed from 0 to 80
I made a review, works correctly, but I found some formal and security issues:
- How exactly you implemented this on the end? In the ticket have to be some conclusion. Name of your branch/commit missing here!
- FE: Why you removed uiKey from definiton table? (https://github.com/bcvsolutions/CzechIdMng/compare/artem/1751-download-workflow?expand=1#diff-fc5979ea444c1686226183f5c49a7110L61)
- FE: Method "getDownloadXmlUrl(reportId)" - wrong name of variable
- DownloaderWorkflowProcessDefinitioTest - missing author and description of class.
- WorkflowProcessDefinitionService - You added some method to the inteface, but JavaDoc missing. JavaDoc must be primary in interface.
- Controller - method "getXml" wrong JavaDoc (it is definitialy not upload).
- Controller - method "getXml", wrong permissions (only READ is required). Missing produces with MediaType.
- In service you created method getBpmnXML and in controller getXML and on FE getDownloadXmlUrl ... methods could have same name in this case (may be getBpmnDefinition).
Updated by Artem Kolychev over 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Artem Kolychev to Vít Švanda
- % Done changed from 80 to 100
artem/1751-download-workflow
added new function for upload workflow definition
Updated by Radek Tomiška over 5 years ago
- Assignee changed from Vít Švanda to Radek Tomiška
Updated by Radek Tomiška over 5 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Artem Kolychev
I did test and code review. It works correctly. I found and fixed some issues:
- missiong javadoc for method WorkflowProcessDefinitionService#getProcessDefinition
- method WorkflowProcessDefinitionService#getProcessDefinitionAsStream renamed as Vitek proposal to #getBpmnDefinition
- tests renamed (typo was there) and moved to better package, but test is nice!
- i found a lot linter issiues on FE (missing semicolons ...), check my commit
- target="blank" should be used for open in new window (in combination with rel="noopener noreferrer")
I merged it into develop, thx for this new feature!
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/70d35204530dc3bd2d18946a211602fe2e56fbae
Updated by Artem Kolychev over 5 years ago
- Status changed from Resolved to Closed