Task #1738
closed
Report Eav attribute
100%
Description
input
- form definition
- name of eav attribute (select box)
- enabled/disabled identity (checkbox)
-value of eav attribute (not required). If this attribute is not filled then all values are written (not blank)
output
- xlsx, json
- table with first name, last name, username, disabled and value of a chosen attribute
tutorial - https://wiki.czechidm.com/tutorial/adm/report_eav_identity
New report will be created.
Related issues
Updated by Radek Tomiška over 5 years ago
Description is missing here, please add product related requirements (and remove link to project from description).
Updated by Marek Klement over 5 years ago
- Subject changed from Message for overloaded main job information to Report Eav attribute
- Status changed from New to In Progress
Updated by Marek Klement over 5 years ago
- Description updated (diff)
- Target version set to Rhyolite (9.7.0)
Updated by Marek Klement over 5 years ago
- Related to Task #1744: Add entity type to label in the form definition selectbox added
Updated by Marek Klement over 5 years ago
- Description updated (diff)
- % Done changed from 0 to 70
Report created
- test created
- tutorial - https://wiki.czechidm.com/tutorial/adm/report_eav_identity
Updated by Marek Klement over 5 years ago
- Assignee changed from Marek Klement to Ondřej Kopr
Updated by Marek Klement over 5 years ago
- Status changed from In Progress to Needs feedback
Updated by Marek Klement over 5 years ago
branch : klementm/1738-report-for-overloaded-main-job-info
Updated by Ondřej Kopr over 5 years ago
- Assignee changed from Ondřej Kopr to Radek Tomiška
Updated by Radek Tomiška over 5 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Marek Klement
I did test, review and report basically works, nice. Here are my notes:
Functionality:
- bug: exception is thrown, when attribute doesn't exist. Add result code execption (better) or report could be empty
- bug: updateState() is not called - report counter is not incremented.
Design:
- [optional] if eav value is given, then FormService.findOwners method could be used to prevent load all identities (you will heve, what you need directly).
Code:
- dto representation of row in report should be created - raw map is used now. See RptProvisioningOperationDto. And remove all remove constants ATTRIBUTE_* from IdentityEavReportExecutor!
- rename constants to PARAMETER_*, if its parameter (e.g. ProvisioningOperationReportExecutor)
- remove IdentityEavReportExecutor .getEavName() method (it's unstable and unused).
- missing @author, javadoc, warnings are shown
Tutorial:
- missing IdM version, module and intro as in other tutorials (e.g. https://wiki.czechidm.com/tutorial/dev/how_to_register_icon#what_do_you_need_before_you_start)
- screenshost schould be in eng
Updated by Marek Klement over 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Marek Klement to Radek Tomiška
Fixed issues after review. I will adjust documentation as soon as possible. Changes are pushed in branch : klementm/1738-report-for-overloaded-main-job-info
Updated by Radek Tomiška over 5 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Marek Klement
- % Done changed from 70 to 100
It's nice and it works, thx!
I just fixed two small issues, which I overlooked before:
- system.out was used for print exception
- pagination was missing
Updated by Radek Tomiška over 5 years ago
- Related to Defect #1785: Report Eav attribute - missign security added
Updated by Radek Tomiška over 5 years ago
I fixed another sonar issues and improve tests:
https://github.com/bcvsolutions/CzechIdMng/commit/110fa44c681f9a92537bfdb78165b5954b57a7e5