Project

General

Profile

Actions
Copy link

Defect #1589

closed

Value of a role attribute can't be deleted

Added by Alena Peterová over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Vít Švanda
Category:
Roles
Target version:
Pyrite (9.5.1)
Start date:
03/30/2019
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

Tested on versions: 9.4.0 (demo), 9.5.0

Steps to reproduce:
  • Assign a role with a role attribute to a user, fill in the attribute value.
  • Try to remove the value of the attribute:
  • Check assigned roles again- the value is still there!

The attribute has no special setting - it isn't required, it doesn't have any default value.

Files

Download all files
role_with_attributes.png (11.1 KB) role_with_attributes.png Alena Peterová, 03/30/2019 12:02 AM
remove_attribute_value.png (19.2 KB) remove_attribute_value.png Alena Peterová, 03/30/2019 12:02 AM
Actions
Copy link
 #1

Updated by Vít Švanda over 5 years ago

  • Assignee changed from Radek Tomiška to Vít Švanda
Actions
Copy link
 #2

Updated by Alena Peterová over 5 years ago

  • Tracker changed from Task to Defect
Actions
Copy link
 #3

Updated by Vladimír Kotýnek over 5 years ago

  • Priority changed from Normal to High

Please fix this bug for 9.5.x.

Actions
Copy link
 #4

Updated by Vít Švanda over 5 years ago

  • Status changed from New to In Progress
  • Target version set to Pyrite (9.5.1)
  • % Done changed from 0 to 40
Actions
Copy link
 #5

Updated by Vít Švanda over 5 years ago

  • Status changed from In Progress to Needs feedback
  • % Done changed from 40 to 100
Actions
Copy link
 #6

Updated by Vít Švanda over 5 years ago

  • Assignee changed from Vít Švanda to Radek Tomiška
Actions
Copy link
 #7

Updated by Vít Švanda over 5 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Vít Švanda
Actions
Copy link
 #8

Updated by Vít Švanda over 5 years ago

  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 100 to 90

Fixed.

Problem was in the realization of the request. There was loaded form-instance from the role-concept and save to identity-role. When value of attribute was erased (in role-concept), the attribute-value in the concept was correctly deleted. But for delete this attribute-value, must this attribute-value (with empty value) exists in the form-instance saved with the identity-role.

  • I implemented mehtod (IdmRoleRequestService.refillDeletedAttributeValue) for create attribute-values for attributes their values are missing in the form-instance.
  • I created tests for this case.
  • I fixed problem in FormableSaveProcessor too. There was definition reloaded from the DB (so subdefiniton was lost). I created test for this case too.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/0807dc6dac59ec9bfcbff5a9c297b9a0a30223fd

Actions
Copy link
 #9

Updated by Vít Švanda over 5 years ago

  • Status changed from In Progress to Needs feedback
Actions
Copy link
 #10

Updated by Radek Tomiška over 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 90 to 100

I did test and review, it works, thx!

Actions
Copy link
 #11

Updated by Radek Tomiška over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF