Defect #1589
closed
Value of a role attribute can't be deleted
Added by Alena Peterová over 5 years ago.
Updated over 5 years ago.
Description
Tested on versions: 9.4.0 (demo), 9.5.0
Steps to reproduce:
- Assign a role with a role attribute to a user, fill in the attribute value.
- Try to remove the value of the attribute:
- Check assigned roles again- the value is still there!
The attribute has no special setting - it isn't required, it doesn't have any default value.
Files
- Assignee changed from Radek Tomiška to Vít Švanda
- Tracker changed from Task to Defect
- Priority changed from Normal to High
Please fix this bug for 9.5.x.
- Status changed from New to In Progress
- Target version set to Pyrite (9.5.1)
- % Done changed from 0 to 40
- Status changed from In Progress to Needs feedback
- % Done changed from 40 to 100
- Assignee changed from Vít Švanda to Radek Tomiška
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Vít Švanda
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 100 to 90
Fixed.
Problem was in the realization of the request. There was loaded form-instance from the role-concept and save to identity-role. When value of attribute was erased (in role-concept), the attribute-value in the concept was correctly deleted. But for delete this attribute-value, must this attribute-value (with empty value) exists in the form-instance saved with the identity-role.
- I implemented mehtod (IdmRoleRequestService.refillDeletedAttributeValue) for create attribute-values for attributes their values are missing in the form-instance.
- I created tests for this case.
- I fixed problem in FormableSaveProcessor too. There was definition reloaded from the DB (so subdefiniton was lost). I created test for this case too.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/0807dc6dac59ec9bfcbff5a9c297b9a0a30223fd
- Status changed from In Progress to Needs feedback
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 90 to 100
I did test and review, it works, thx!
- Status changed from Resolved to Closed
Also available in: Atom
PDF
