Task #1460
closed
SoD: Create default approval process
Added by Vít Švanda almost 6 years ago. Updated almost 6 years ago.
100%
Updated by Vít Švanda almost 6 years ago
- % Done changed from 0 to 50
- Method for get incompatibilities of request moved to role-request-service and modifed for returns incompatibilities only for added role in the request.
- Added approval cycle to changepermission WF process. Approving all identities has roles defined in property (by default is name of role "Incompatibility").
https://github.com/bcvsolutions/CzechIdMng/commit/f1d6164ae8fa996aee7830d51a726c16ce603bc7
https://github.com/bcvsolutions/CzechIdMng/commit/e044c54fc4a3da521554be117566c93a42f46467
Updated by Vít Švanda almost 6 years ago
- % Done changed from 50 to 80
- Implementation completed (fixies, added state of concept to concept table ...)
- Created test for approval the incompatible roles.
Test: https://github.com/bcvsolutions/CzechIdMng/commit/9fa6759f06556adea935ca2382e46ec941eb541f
Updated by Vít Švanda almost 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 80 to 90
Updated by Vít Švanda almost 6 years ago
- Here was problem in the situation, when all user tasks were skipped, then disapprove way was choosed.
- I set default way and modified the conditions.
- I created test too.
https://github.com/bcvsolutions/CzechIdMng/commit/871e0ef6750d3855f0f616e67a5b603de98dff46
Updated by Radek Tomiška almost 6 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 90 to 100
I did test and review, it works and code looks nice, thx!
Note: i added eav validations for the concept detail (i noticed it here, but it's not related).
Note: Improvement in #1480 will be helpful here too :)