Task #1304
closed
New version for core 9.x and support for reset by personal number
Added by Roman Kučera about 6 years ago.
Updated about 6 years ago.
Description
New version of password reset modul for product version 9.x
Implementing support for resetting password by user's personal number.
Files
- Status changed from New to In Progress
- % Done changed from 0 to 60
Added support for personal number (externalCode) on BE
On FE fixed label for attribute which will be used for finding identity. In current version its showing username in both modes (username, email). Now it will dynamically show the correct label for each type (username, email, externalCode) It supports multivalue as well. So if you use more attributes in configuration it will display all labels separated by comma.
Upgrade of IdM version from 8.1.2 to 9.2.0
Changed property idm.sec.pwdreset.allowed.attrs to idm.pub.pwdreset.allowed.attrs (changed from secure to public). This way I can use it for displaying correct label. After consultation with Ondra there is no need to have this property as secure.
Implementation in branch rkucera/1304-support-personal-number
- Status changed from In Progress to Needs feedback
- Assignee changed from Roman Kučera to Ondřej Kopr
- % Done changed from 60 to 90
- File pwd_attrs.png pwd_attrs.png added
- Assignee changed from Ondřej Kopr to Roman Kučera
- Target version set to 1.4.0
- % Done changed from 90 to 100
I checked your solution:
- I updated documentation:
- add missing tests for personal code,
- trim localization key in frontend,
- merged into develop (branch was deleted).
My commit: https://git.bcvsolutions.eu/modules/password-reset/commit/a60078241fe3dd22f08ccfb18db28571eafa8eef
Your behavior works correctly, change label dynamical is good idea. Result with allowed all attributes can be:
In method IdentityResolver#findByAttribute can be used attributes map that is inside filter, but for now it is working correctly. This is only about some refactor.
Please check if is my changes is good for you :D. After check you can close the ticket, thank you :)
- Status changed from Needs feedback to Closed
Thx for review. After your changes its works still corectlly.
Also available in: Atom
PDF