Defect #1214
closed
Notification during start of validity identity was send twice
100%
Description
Notification topic: CoreModuleDescriptor.TOPIC_PASSWORD_CHANGED was send twice during identity change state to valid.
Please create two different topic for TOPIC_PASSWORD_CHANGED (processors IdentityPasswordChangeNotificationProcessor and IdentitySetPasswordProcessor) template in one case sends password during another password wasn't send (also username doesn't exists in first case).
Add some skip to IdentityPasswordChangeNotificationProcessor (eq SKIP_NOTIFICATION).
Thank you for fix this.
Updated by Radek Tomiška over 6 years ago
Implementation steps:
- two notification topics will exist - for change and set password. The same template will be used as default (can be changed by notification configuration).
- event with skipping notification from 'set' password will be propagated into 'change' password processing
- username parameter will be available in both notification templates .
Updated by Radek Tomiška over 6 years ago
- Status changed from New to In Progress
Updated by Radek Tomiška over 6 years ago
- % Done changed from 0 to 90
I created new topic 'core:passwordSet', add username parameter and skip duplicate notification, when password is set.
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/2efd82f54864d290061365e92fc7ca736629fcb9
Could you do a feedback, pls?
Updated by Radek Tomiška over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Ondřej Kopr
Updated by Ondřej Kopr over 6 years ago
- Assignee changed from Ondřej Kopr to Vít Švanda
Updated by Vít Švanda over 6 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 90 to 100
I tested it and works well (only one notification is send now). Thanks for that.