Task #1186
closed
Agenda of requests - implementation
Added by Vít Švanda almost 6 years ago. Updated over 5 years ago.
100%
Related issues
Updated by Vít Švanda over 5 years ago
- Target version changed from Malachite (9.0.0) to Moonstone (9.1.0)
Updated by Vít Švanda over 5 years ago
- % Done changed from 0 to 60
Previous naive implementation of searching DTOs (search all UUID values from filter in DTO) via request REST is not sufficient.
In case of Bussiness role we want to searching by one ID in two fields (sub/superior).
I created new implementation, where was added new annotation for mark fields (getters) in the filter object. This annotation contains name of field in DTO. That marked field value will be searching only in this field in DTO.
Updated by Vít Švanda over 5 years ago
- % Done changed from 60 to 70
I implemented referential integrity on item delete (others items could be children (their DTOs) of deleted item).
Updated by Vít Švanda over 5 years ago
I implemented referential integrity on terminated item (others items could be children (their DTOs) of terminated item) in realization of request (items).
Updated by Vít Švanda over 5 years ago
Approvers for change of role are envolved as:
- First try to find guarantees for given role. If any guarantees will be found, then returns they.
- Without guarantees try to find approvers with role defined in property file {@link RoleConfiguration#getRoleForApproveChangeOfRole()} 'idm.sec.core.wf.approval.role-change.role'.
Updated by Vít Švanda over 5 years ago
- % Done changed from 70 to 80
- Created first tests for RequestManager
- Fixed problem with canceling WFs on delete managed entity. Problem occurred after canceling the WF process from which was delete invoked .
- All is merged to develop (12 700 rows :-))
- First documentation in the wiki https://wiki.czechidm.com/devel/documentation/roles/dev/universal_requests
Updated by Vít Švanda over 5 years ago
- Basic functionality is done.
- Created tests for basic usecase ... coverage of new code is cca 60%.
- All is merged to develop (12 700 rows :-))
- First documentation in the wiki https://wiki.czechidm.com/devel/documentation/roles/dev/universal_requests
Remains:
- Completed a tests
- Completed documentation
- Localizations for WFs, Result codes, permissions
Updated by Radek Tomiška over 5 years ago
I did a test, all UC works:
- when requests are disabled, everything works as usual
- role request is executed correctly without approving
- role request is executed correctly with approving (subprocesses included)
I fixed only minor FE and security issues. I will do a review tomorrow.
Updated by Radek Tomiška over 5 years ago
- Related to Task #1219: Approval process for change of idm-role added
Updated by Radek Tomiška over 5 years ago
- Status changed from In Progress to Closed
- % Done changed from 80 to 100
I tested it on MSSql , all UC above works. I did review (API, entities, change script) and code looks ok, i didn't find anything suspicious. Thx for this big feature!
Remaining (non blocking) features will be implemented in #1219.