Task #1048
closed
Check password policy generating
100%
Description
When password generating policy does not have maximum length set. Then IdM gets stuck on geterating new password when creating new account. I came upon this on version 7.6.1. I do not need it to be fixed on 7.6.1, because problem can be solved by setting maximum password length. However we should verify that this problem is not present in current develop.
Updated by Ondřej Kopr over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Peter Štrunc
- Target version changed from Hematite (8.0.0) to Jade (8.1.0)
- % Done changed from 0 to 90
I found the problem:
in password generator was defined if max length == null, then set max length = Integer.MAX_VALUE. This is probably problem on slow computers/servers. I made defensive fix with check null and zero and then set higher of minimal values length (see commit).
Tests for this scenario was also added (create new junit test, all next behavior is tested in integration test). Thank you Peter for report the bug. Please could you make a review? Thank you.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/1df7d3604f93500c1f82d6af749ea02dfaced156 (develop)
Updated by Radek Tomiška over 6 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Peter Štrunc to Ondřej Kopr
- % Done changed from 90 to 100
I did test and review, it works, thx!
I added note about default generated password length into doc: https://wiki.czechidm.com/devel/documentation/security/dev/password-policies#password_length