Task #986
closedModule Implementation
100%
Description
Implement the module
Updated by Radek Tomiška over 5 years ago
I found notes from feedback, what i did a few months ago, here they are:
- I fixed pom file, dependencies etc. - module can be build now and can be used under dev profile - https://git.bcvsolutions.eu/modules/lic/commit/ea0df0870c4d84c372fdde2910268ca373c3047a.
- entity model contains circular relation from license to identity
- Entity names should be in singular. Rest endpoints (and collections) in plurar - https://github.com/bcvsolutions/CzechIdMng/blob/develop/CONTRIBUTING.md#coding-style-convention
- License 'state' attribute should be enumeration (string now) - audit is missing for this attribute.
- indexes in entities missing
- remove schema name from change scripts (could be different by environment)
- referential integrity is missing - delete guarantee identity
- ERD in git is missing
- security is not implemented - is needed to implement evaluators by identity to licenses. Rest controllers should generalize AbstractReadWriteDtoController. Use AbstractReadWriteDtoControllerRestTest for integration tests.
- entity event processors for contracts are in wrong package ('..identity')
- entity event processors for licenses are missing - will be usable e.g. for provisioning
- example topic remains in module descriptor
- example module initializer used - can be removed
- services contain unimplemented methods
- 'assignedIdentity' used in filter is duplicate
- FE agendas should be redesigned to tabs, then algorithms could be simpler - license serie and license item could be added separately. Some user friendly bulk actions can be designed. FE agendas are not done (PoC) - e.g. select box usage (wf), missing refreshes, showLoading, wf localization ...
- tests are not working (...#findLicensesForSeries)
- readme, documentation is missing
I know some points are already fixed after consultation, i added all notes for check list.
Updated by Vladimír Kotýnek almost 3 years ago
- Status changed from New to Rejected
Module replaced with Property module https://redmine.czechidm.com/projects/prp