Project

General

Profile

Actions

Task #965

closed

Add password prevalidation support to password reset module

Added by Radek Tomiška almost 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Patrik Stloukal
Target version:
Start date:
02/14/2018
Due date:
% Done:

100%

Estimated time:
2.00 h
Owner:

Description

Add password prevalidation support to password reset module - to public password reset page.


Related issues

Precedes IdStory Identity Manager - Task #689: Show available special characters for password policy to userClosedPatrik Stloukal

Actions
Actions #1

Updated by Radek Tomiška almost 7 years ago

  • Precedes Task #689: Show available special characters for password policy to user added
Actions #2

Updated by Patrik Stloukal almost 7 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Patrik Stloukal to Radek Tomiška
  • % Done changed from 0 to 90

prevalidation added to pwd-reset, this preValidation is similar to public password-change

commit: https://git.bcvsolutions.eu/modules/password-reset/commit/c6563d1359cc953239431c4df76fb3933bb2477d

Actions #4

Updated by Radek Tomiška over 6 years ago

  • Assignee changed from Radek Tomiška to Peter Štrunc
Actions #5

Updated by Petr Michal over 6 years ago

  • Priority changed from Low to Normal

I found that, when I used button "I have verfication code" which should only redirect me to another form, everything works fine, but I have some password validation errors in log.
Its is most likely caused by this task.

Actions #6

Updated by Peter Štrunc over 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Peter Štrunc to Patrik Stloukal

Review is OK except the issue from previous comment.

Actions #7

Updated by Patrik Stloukal about 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Patrik Stloukal to Peter Štrunc

the issue has been removed in core module, so I updated password reset module.
I tested this modification and it is working.
Please look on my implementation.

commit: https://git.bcvsolutions.eu/modules/password-reset/commits/pstloukal/965-pwd-prevalidation

Actions #8

Updated by Patrik Stloukal over 5 years ago

  • Assignee changed from Peter Štrunc to Ondřej Kopr

i figure out one proble: when token is used and is not valid, it will pop out window with error, but prevalidation would disappear
so i fixed this issue and in cor emodule, there was different one line (because it is quite long ago), so i changed that too.
I tested it now again and it is working

Please look on this too Ondra.

commit:
https://git.bcvsolutions.eu/modules/password-reset/commit/d86971c415a0b6b1df39628401ac44638158e5f8

Actions #9

Updated by Ondřej Kopr over 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondřej Kopr to Patrik Stloukal
  • Target version set to 1.5.0
  • % Done changed from 90 to 100

Thank you I made review and its working correctly.

Actions #10

Updated by Radek Tomiška over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF