Project

General

Profile

Actions
Copy link

Task #963

closed

Add message with accounts after password is reseted

Added by Radek Tomiška almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Peter Štrunc
Target version:
-
Start date:
02/15/2018
Due date:
02/15/2018
% Done:

100%

Estimated time:
8.00 h
Owner:

Description

Show message on FE with accounts after password is reseted - the same message as on content PasswordChange#passwordChange() with success account, failed accounts and info about password was not reseted on an account (no account is available).

Related issues

Follows password-reset - Task #955: Disable password reset in IdMClosedPatrik Stloukal02/14/201802/14/2018

Actions
Actions
Copy link
 #1

Updated by Radek Tomiška almost 7 years ago

  • Due date set to 02/15/2018
  • Start date changed from 02/13/2018 to 02/15/2018
  • Follows Task #955: Disable password reset in IdM added
Actions
Copy link
 #2

Updated by Patrik Stloukal almost 7 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Patrik Stloukal to Radek Tomiška
  • % Done changed from 0 to 90

i edited PasswordResetDto, added List<OperationResult> from processor, because of sucess/fail password reset on systems, edited DefaultPasswordResetRequestService to add operations results to dto
on FE edited VerifyReset.js method _afterSave to show messages (like in pwdChange). Added 3 messages to pwdReset localization.

commit: https://git.bcvsolutions.eu/modules/password-reset/commit/0ade2cd0eaad74e5a0b37e2470ea8ab6349e427c

Radek, could you please look on my implementation and write feedback?

Actions
Copy link
 #3

Updated by Radek Tomiška over 6 years ago

  • Assignee changed from Radek Tomiška to Peter Štrunc
Actions
Copy link
 #4

Updated by Peter Štrunc over 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Peter Štrunc to Patrik Stloukal

I did review. Here are my notes:

  • Refactor new code in Realization/backend/src/main/java/eu/bcvsolutions/idm/pwdreset/service/impl/DefaultPasswordResetRequestService.java. Try to avoid long methods and extensive indentations. Also it is not recommended to nest lambdas, because it becomes unreadable.

Otherwise it is awesome, thanks ;)

Actions
Copy link
 #5

Updated by Patrik Stloukal over 6 years ago

  • Assignee changed from Patrik Stloukal to Peter Štrunc

ok so i refractored this code, changed lambdas, i deleted duplicate code

commit: https://git.bcvsolutions.eu/modules/password-reset/commit/1c2399aeb5f62cce79a06f507b83086833280708

Actions
Copy link
 #6

Updated by Peter Štrunc over 6 years ago

I refactored the code a little bit to get rid of the indentation. I will merge the code to develop.

Actions
Copy link
 #7

Updated by Peter Štrunc over 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

Merged to dev. Closing

Actions
Copy link

Also available in: Atom PDF