Project

General

Profile

Actions

Feature #925

closed

Password generate

Added by Ondřej Kopr almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Target version:
-
Start date:
01/23/2018
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Create new feature password generate:
  • new component for password change form,
  • new logic - password generate (password will be generate directly without create token),
  • tests,
  • documentation
Actions #2

Updated by Ondřej Kopr almost 7 years ago

Update password reset module to version 7.7.0 is needed (for now will be upgrade only to 7.7.0-SNAPSHOT).

Actions #3

Updated by Ondřej Kopr almost 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 0 to 90

Update documentation: https://wiki.czechidm.com/devel/documentation/modules_pwd
https://wiki.czechidm.com/tutorial/adm/modules_pwdreset#password_generate

I must made little change in acc module: https://github.com/bcvsolutions/CzechIdMng/commit/72d09ee37a8807035152df21eedf327ae1bd5bde

I upgrade password reset module to version 7.7.0-SNAPSHOT after release this version I will remove SNAPSHOT version.

Commit: https://git.bcvsolutions.eu/modules/password-reset/commit/fb358da5e25c9fb40cd987331aa6321ad70df6ca
+ tests are included.

I have some unclear things:
  • new group permission PASSWORDRESET has permission CREATE for password generate and future request password reset, is this it's good?
  • we talk about change in ACC module, I removed clear password change dto, should I add the processor to core to clear this values? I checked this now behavior and password change works well.

Please Radek could you made review?

Actions #4

Updated by Ondřej Kopr almost 7 years ago

I'm sorry I forgot unless dto in commit (PasswordGenerateDto.java), I already removed it

Actions #5

Updated by Ondřej Kopr almost 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 80

I found problem with permission in password change form, First I will solve the problem and then I will give you feedback back.

Actions #6

Updated by Ondřej Kopr almost 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 80 to 90

Thanks Radek for your hint with permissions. There is commit: https://git.bcvsolutions.eu/modules/password-reset/commit/d4540f359735a06ff774e90b265129ef43fc09e6

Please could you fix problem with second permission (Users and Users (IdmIdentity)) thank you :)

Actions #7

Updated by Radek Tomiška almost 7 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

I did test, review and little refactoring (css ...).
Thx for ths new feature, it's nice!

Actions

Also available in: Atom PDF