Task #922
closed
IdentityService - find valid identities by valid assigned role
100%
Description
Add method to IdentityService - find valid identities by valid assigned role. This method should be used on all places, where identities by role is needed - e.g. for approve tasks, send notifications (see certificate module notifications or vs module - approvers) => task and notification should be send to active identities with valid role.
Updated by Radek Tomiška over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 0 to 90
I added new method 'IdmIdentityService#findValidByRole(role)' and used her:
- in code - find identities by role
- in acc module in provisioning brake notifications
- in crt module for sending notifications and finding approvers
- in vs module for finding approvers
Note: I fixed original method 'IdmIdentityService#findValidByRole(role)' - i refactored method to criteria usage (joins on identity, contract and roles were used => duplicate identities were returned. I made this repository method deprecated and will be removed, in another release - i did not find an usage, but i preserved her just for sure).
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/e9535bef50b1bca309bb21c2a07f80e23ae5ac6a
Could you pls do a feedback?
Updated by Ondřej Kopr over 6 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 90 to 100
I made feedback:
thanks for update javadoc, new util method is awesome, test are also included, I didn't find any problem, thank you
Updated by Radek Tomiška about 6 years ago
- Status changed from Resolved to Closed