Project

General

Profile

Actions

Task #879

closed

HrEndContractProcessIntegrationTest consume ~5 minutes

Added by Ondřej Kopr about 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Test
Target version:
Start date:
12/19/2017
Due date:
% Done:

100%

Estimated time:
Owner:

Description

In HrEndContractProcessIntegrationTest tests is assigned all created roles in all test. This test consume ~5 minutes during testing. Please fix this behavior.

    private void addRolesToContract(IdmIdentityContractDto contract) {
        roleService.find(null).forEach(role -> {
            IdmIdentityRoleDto d = new IdmIdentityRoleDto();
            d.setRole(role.getId());
            d.setAutomaticRole(false);
            d.setIdentityContract(contract.getId());
            identityRoleService.save(d);
        });
    }

Files

tests.png (35 KB) tests.png Ondřej Kopr, 12/19/2017 10:51 AM
new.png (26.4 KB) new.png Ondřej Kopr, 12/19/2017 11:33 AM
Actions #1

Updated by Ondřej Kopr about 7 years ago

  • Subject changed from HrEndContractProcessIntegrationTest consume 2 minutes to HrEndContractProcessIntegrationTest consume ~5 minutes
  • Description updated (diff)
Actions #2

Updated by Ondřej Kopr about 7 years ago

  • File new.png new.png added
  • Status changed from New to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 0 to 90

I upgraded this test by add pageable for role request: https://github.com/bcvsolutions/CzechIdMng/commit/9e236b5e4e3bb4e1d76a8dcfbc4f1068109272c7

Result:

Please Radek when you will be start all tests check if all tests passed (on Jenkins and my computer is this ok). Thank you.

Actions #3

Updated by Radek Tomiška almost 7 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

It's ok, thx :)

Actions

Also available in: Atom PDF