Project

General

Profile

Actions

Task #853

closed

Boolean system configuration options cannot be unset

Added by Peter Štrunc over 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
High
Assignee:
Radek Tomiška
Category:
Systems
Target version:
Start date:
11/27/2017
Due date:
% Done:

100%

Estimated time:
Owner:

Description

If connector defines a required configuration property of boolean type, that property must be always set to true. When trying to unset this property, it becomes red and configuration cannot be saved. See attached gif. Experienced on 7.6.0-SNAPSHOT.


Files

required_bool.gif (79.1 KB) required_bool.gif Peter Štrunc, 11/27/2017 03:08 PM

Related issues

Related to IdStory Identity Manager - Task #1052: delete non empty EAV (even with values)RejectedRadek Tomiška04/04/2018

Actions
Actions #1

Updated by Peter Štrunc over 6 years ago

  • Description updated (diff)
Actions #2

Updated by Vít Švanda over 6 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Vít Švanda to Peter Štrunc

Why is this attribute set as mandatory?

A mandatory checkbox is generally quite extreme. I personally know only one case when this combination was needed. Specifically, we needed the user to confirm the license terms (they must tick it).
If you need three states of this attribute (true/false/ null), maybe enumeration will be better choice.

P.s. Greate GIF :-).

Actions #3

Updated by Peter Štrunc over 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Peter Štrunc to Vít Švanda

This is configuration property from Tirasa's AD connector. I think that they are trying to say, that the value must be set to something, so solution would be not to control boolean checkboxes on required constraint i think. I cannot think of any other interpretation of required boolean property either.

See https://github.com/Tirasa/ConnIdADBundle/blob/master/src/main/java/net/tirasa/connid/bundles/ad/ADConfiguration.java#L372

Actions #4

Updated by Vít Švanda over 6 years ago

  • Status changed from In Progress to New
  • Assignee changed from Vít Švanda to Radek Tomiška
  • Priority changed from Urgent to Normal

Ok, we will used selectbox with True/False value for this case (required checbox).
- Temporaly solution: Manualy (via UI) set attribute definition for the checbox as not required.

Actions #5

Updated by Petr Michal about 6 years ago

  • Priority changed from Normal to High

We encountered this problem on two other projects.
After consultation with team. I increased priority of the task.

Actions #6

Updated by Radek Tomiška almost 6 years ago

  • Status changed from New to In Progress
  • Target version set to Jade (8.1.0)
Actions #7

Updated by Radek Tomiška almost 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 0 to 90

I changed face for required boolean attribute generated for connector configuration - it's rendered as required boolean select box with 'Yes / No' options.

I improved saving filled configuration (~eav form) values - filled form values are saved only.

Could you do a feedback please?

Actions #8

Updated by Radek Tomiška almost 6 years ago

  • Related to Task #1052: delete non empty EAV (even with values) added
Actions #9

Updated by Ondřej Kopr almost 6 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 90 to 100

Works awesome! I tested on system and identity eav's. I changed face type to selectBox and now is possible unset the value. Thank you for the feature.

Actions #10

Updated by Radek Tomiška almost 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF