Project

General

Profile

Actions
Copy link

Task #850

closed

Sync of contract relationships - Start HR process after sync end.

Added by Vít Švanda over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vít Švanda
Category:
Synchronization
Target version:
Forsterite (7.6.0)
Start date:
11/27/2017
Due date:
% Done:

100%

Estimated time:
Owner:

Description

- Does not start HR processes for each synced contract => we need can skip start of HR process during sync
- Start HR processes after sync end

Actions
Copy link
 #1

Updated by Vít Švanda over 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Vít Švanda over 6 years ago

  • % Done changed from 0 to 70
  • All HR processes are skiped during sync of contract relationships.
  • Added boolean attribute for turn on/off start HR processes after succes end of contract sync.
  • After end of sync is start task HrEndContract. Maybe should be also started LRT for other HR processes (start, exclude)?
  • Created change script and tests for sync.
Actions
Copy link
 #3

Updated by Vít Švanda over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 70 to 90
Actions
Copy link
 #4

Updated by Vít Švanda over 6 years ago

  • Assignee changed from Radek Tomiška to Ondřej Kopr
Actions
Copy link
 #5

Updated by Ondřej Kopr over 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Ondřej Kopr to Vít Švanda
  • % Done changed from 90 to 80

I made review synchronization and hr process works well, but second synchronization wasn't processed any items, we found 'bug' in scheduled tasks.

After some consultation we decided that scheduled task without id process all items
commit: https://github.com/bcvsolutions/CzechIdMng/commit/2802d83d3225a032e9c4d28a561b187beadd6ca5

please check this solutions.

Actions
Copy link
 #6

Updated by Vít Švanda over 6 years ago

Here was problem with start HR processes.
  • I had to modified them for start processes via scheduled tasks (not directly via executors), because we do not want start processes for every contracts everytime.
Actions
Copy link
 #7

Updated by Vít Švanda over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Ondřej Kopr
  • % Done changed from 80 to 90

I had to repaired some tests. Now works.

Actions
Copy link
 #8

Updated by Radek Tomiška over 6 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Ondřej Kopr to Vít Švanda
  • % Done changed from 90 to 100

It works and code looks nice, thx.

Note: We need to improve statefull schaduled tas api. Work with sateful task is really black magic.

Actions
Copy link

Also available in: Atom PDF