Project

General

Profile

Actions
Copy link

Task #84

closed

Code review

Added by Ondřej Kopr over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Frontend
Target version:
Amethyst
Start date:
08/09/2016
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Fix code by new linter.

Check syntax, fix errors and warnings.

Related issues

Related to IdStory Identity Manager - Defect #107: Používání fetch v javascriptu = nefunkčnost v nezanedbatelné části prohlížečůClosedRadek Tomiška08/21/2016

Actions
Actions
Copy link
 #1

Updated by Ondřej Kopr over 7 years ago

Success fix:
  • Components
  • advenced
  • basic
  • layout
  • modules
  • core - content

To .eslintrc was add react/no-did-update-set-state to warnings. Is nessesary to repair bug with second render more info : https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-did-update-set-state.md Found in Subcordinates.js line 25

Actions
Copy link
 #2

Updated by Ondřej Kopr over 7 years ago

  • Status changed from New to Needs feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to Resolved

Test and review - ok.

Actions
Copy link
 #4

Updated by Radek Tomiška over 7 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #5

Updated by Radek Tomiška over 7 years ago

  • Related to Defect #107: Používání fetch v javascriptu = nefunkčnost v nezanedbatelné části prohlížečů added
Actions
Copy link

Also available in: Atom PDF