Project

General

Profile

Actions

Task #818

closed

Make version compatible with core 7.5.x

Added by Peter Štrunc over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Target version:
-
Start date:
11/03/2017
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Goal of this ticket is to upgrade password reset module to core version 7.5.x.


Related issues

Related to IdStory Identity Manager - Feature #363: Password reset moduleClosedPeter Štrunc09/04/2017

Actions
Actions #1

Updated by Ondřej Kopr over 6 years ago

  • Assignee changed from Peter Štrunc to Patrik Stloukal
Actions #2

Updated by Patrik Stloukal over 6 years ago

  • Status changed from New to In Progress

upgraded backend, test is succesfull, translated some en localization, testing

Actions #3

Updated by Patrik Stloukal over 6 years ago

  • % Done changed from 0 to 90

tested module, working fine

I found some small issues:
- in documentation is idm.sec.reset.password.allowed.attrs, but it is working with idm.sec.pwdreset.allowed.attrs (https://wiki.czechidm.com/tutorial/adm/modules_pwdreset)

- and I was confused, because I thought that reset password is not working with more systems, but then I found out, that pwdreset checked only default password policy, but provisioned password even on other system, where the password could not meet that system password policy -- but I am not sure if it is ok or not

commit :
https://git.bcvsolutions.eu/modules/password-reset/commit/ba25d1674be52741c5a01753e6bd6519508ad003

Actions #4

Updated by Radek Tomiška over 6 years ago

Actions #5

Updated by Patrik Stloukal over 6 years ago

  • Assignee changed from Patrik Stloukal to Peter Štrunc

ok my bad,
it is working correctly with:
idm.sec.acc.processor.identity-password-validate-processor.eventTypes=PASSWORD,PASSWORD_RESET

and it is awesome

Actions #6

Updated by Ondřej Kopr over 6 years ago

  • Assignee changed from Peter Štrunc to Ondřej Kopr
Actions #7

Updated by Ondřej Kopr over 6 years ago

  • Status changed from In Progress to Needs feedback
Actions #8

Updated by Ondřej Kopr over 6 years ago

  • Status changed from Needs feedback to Resolved
  • % Done changed from 90 to 100

Setup this module on my local environment and after i made this check behavior and also code review.
Code looks nice, thanks for add missing localization item.

  • New tag for this version missing, i already created the tag,
  • version of Realization/frontend/package.json was "version": "7.1.0-snapshot", i already fix it,
  • version of module is still snapshot, i already fix this.
Actions #9

Updated by Ondřej Kopr over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF