Project

General

Profile

Actions
Copy link

Task #785

closed

Notification configuration - add filter

Added by Radek Tomiška over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Patrik Stloukal
Category:
Notification
Target version:
Forsterite (7.6.0)
Start date:
10/24/2017
Due date:
% Done:

100%

Estimated time:
4.00 h
Owner:

Description

Add filter to notification configuration table:
- filter by topic, level, channel, template
- implement search as criteria api

Actions
Copy link
 #1

Updated by Ondřej Kopr over 6 years ago

  • Assignee changed from Radek Tomiška to Patrik Stloukal
Actions
Copy link
 #3

Updated by Patrik Stloukal over 6 years ago

created: notification configuration filter (backend)
tests

Actions
Copy link
 #4

Updated by Patrik Stloukal over 6 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Patrik Stloukal to Radek Tomiška
  • % Done changed from 0 to 90
Actions
Copy link
 #5

Updated by Patrik Stloukal over 6 years ago

  • Assignee changed from Radek Tomiška to Ondřej Kopr
Actions
Copy link
 #6

Updated by Ondřej Kopr over 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Ondřej Kopr to Patrik Stloukal
  • % Done changed from 90 to 80
I did review:
Smaller things I've already fixed
  • formatting in IdmNotificationConfigurationFilter,
  • remove your unfoget link 'Realization/frontend/czechidm-acc/czechidm-acc'
Things you have to fix:
  • in DefaultIdmNotificationConfigurationService in method toPredicates you use toLower, but only on one site, you must add toLowerCase to string from filter,
  • this isn't really necessary but is it will be nice if you add java doc for private methods in test,
  • change state filterOpened to true, in template agenda it was already change and every another notification agenda has filter by default open,
  • in detail notification configuration is channel pick by select box, change current textfield filter to this selectbox,
  • remove like from notificationType, like is in this case useless,
  • change Basic.EnumSelectBox to Advanced.Filter.EnumSelectBox, from some reason this works, but in filter we use Advanced.Filter.EnumSelectBox.

please before you add some ticket to review merge actual develop to your branch and test it again with current develop branch, you branch is from 7.5.0 current is 7.5.2.

After you resolve this issues and merge develop into your branch, give me this ticket back

commit: https://github.com/bcvsolutions/CzechIdMng/commit/9f2efdd7e534d2f331ae7f4374da941508e44738

Actions
Copy link
 #7

Updated by Patrik Stloukal over 6 years ago

fixed mistakes from feedback,
found another bug: after closing detail, filter is not working

Actions
Copy link
 #8

Updated by Patrik Stloukal over 6 years ago

testing, looking for bug

Actions
Copy link
 #9

Updated by Ondřej Kopr over 6 years ago

  • Assignee changed from Patrik Stloukal to Ondřej Kopr

I will fix the problem with show modal window and filter values.

Actions
Copy link
 #10

Updated by Ondřej Kopr over 6 years ago

  • Assignee changed from Ondřej Kopr to Patrik Stloukal

So problem with modal window and missing form field, isn't your fault, after you remove all logs and clean your code you can merge your branch into develop.

After you will be done with merge, give this ticket to Radek for last feedback, thank you :-)

Filtr works awesome, good job.

Actions
Copy link
 #11

Updated by Radek Tomiška over 6 years ago

I've fixed using duplicate refs in one component, when modal window is used (core, acc) - this is the reason why filter not working.

Fix filter usage pls in your bran - inspiration can be found in AccountTable component (acc module) - is needed to wrap filter into standalone component.

Actions
Copy link
 #12

Updated by Patrik Stloukal over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Patrik Stloukal to Radek Tomiška
  • % Done changed from 80 to 90

filter fixed, branch merged to develop
so please look on that filter, now it should be ok

Actions
Copy link
 #13

Updated by Radek Tomiška over 6 years ago

  • Assignee changed from Radek Tomiška to Vít Švanda
Actions
Copy link
 #14

Updated by Vít Švanda over 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Patrik Stloukal

Please check where are all required changes/commits ... I am confusing from this now.

Actions
Copy link
 #15

Updated by Patrik Stloukal over 6 years ago

  • Assignee changed from Patrik Stloukal to Vít Švanda

sorry, I merge it locally into develop.. now it should be pushed

Actions
Copy link
 #16

Updated by Vít Švanda over 6 years ago

  • Status changed from In Progress to Needs feedback
Actions
Copy link
 #17

Updated by Vít Švanda over 6 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Vít Švanda to Patrik Stloukal
  • Target version set to Forsterite (7.6.0)
  • % Done changed from 90 to 100

I tested it in on the develop and works fine.

Actions
Copy link

Also available in: Atom PDF