IdStory Identity Manager

i worked on: two new configuration properties
Update design of IdmCoreChangeIdentityRole,

tests complete, working on documentation

documentation complete,

please revise,
and merge...
commits : https://github.com/bcvsolutions/CzechIdMng/commit/e8374e376edfc0ed6361b633f9415dfa289b44c6
https://github.com/bcvsolutions/CzechIdMng/commit/b0b82cfa43ebb1f8cbc86af119f0422f966ec343

documentation: https://wiki.czechidm.com/devel/adm/roles#sending_notifications
https://wiki.czechidm.com/devel/dev/security/change-user-permissions?s%5B%5D=change&s%5B%5D=identity#sending_notifications
https://wiki.czechidm.com/devel/dev/configuration/backend#notification_from_workflow

I did review, i found these issues:

• in template IdmCoreChangeIdentityRole, macro printRole has as parameter color, but in macros isn't this attribute used, please remove this attribute, is useless,
• same use case as above in template IdmCoreChangeIdentityRoleRequester,
• IdmCoreChangeIdentityRoleRequester and another xml files missing last lines please add this lines, this is possible problem while parsing xml files,
• if is possible try little format all templates that you edited (different tabs and etc.),
• test are awesome, but set creator is useless, please remove this: "organization.setCreator("ja");" and change czech language in strings, we are worldwide :),
• this isn't really necessary but is it will be nice if you add java doc for private methods in test.

I made tests for helpdesk, usermanager, manager, security and also test split to subprocess. Test with same or different applicant and requester i also made, your algorithm works awesome! Thanks for that. Backward compatibility also works.

i already merged develop into your branch and resolve conflicts in CoreModuleDescriptor

After you will resolve feedback give me this task back.

i removed issues from feedback and modified tables in IdmchangeIdentityRoleRequester and IdmchangeIdentityRole (padding and color-yellow was too much bright)

I did feedback, every things works as ticket describes. Only thinks to discussion is design of notification template. Thank you Patrik for this new feature.

Radek could you make a review of review? Thank you :).

• Use implementerId instead requestor.
• Use equlas for compare IDs.
• After return request have to be task assigned on the implementer not applicant.

This feature will not be in 7.6.0. It must be consults this task with Marcel.

modified test and notification templates, testing

commit: https://github.com/bcvsolutions/CzechIdMng/commit/71e65dc9dd4e45a00c993a947cfa42d00fcafc18

i resolved issues from feedback, please send review

Why you create new branch? Now is all your changes in one commit and I don't see only last changes :(

• approve, disapprove and return task (applicant is different person than person for what is role request),
• approve, disapprove and return task (applicant is same person)
• and both above use case try with different application property settings.

new configurations can be found there:
https://wiki.czechidm.com/7.6/dev/configuration/backend?s[]=configuration#notification_from_workflow
https://wiki.czechidm.com/tutorial/adm/role_change_notification_configuration

Your new changes works, please Vitek could you made feedback for Patrik? Thank you.

I did review and test. Works fine. I found problem with load implementer user in the WF (loading by user created the event). I fixed it (implementerId variable is used now).