Defect #683
closed
Fix sent attribute in email notification
100%
Description
On project is not filled attribute sent while send emails, but email was sent. Please debug and check why is not this attribute filled.
Add this fix to hotfix and develop.
Updated by Ondřej Kopr over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 0 to 90
After long debugging we found problem place: class EmailCallback method onComplete catch error from asserts. This problem was fixed.
please Radek could you make a review? Thank you.
i merged this fix to hotfix and develop
commit: https://github.com/bcvsolutions/CzechIdMng/commit/3cbb0c5225365503fd23682b8c191c6f76662edc
Updated by Radek Tomiška over 6 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- Target version set to Diamond (7.4.0)
- % Done changed from 90 to 100
Notification agenda works, but i was not able to reproduce original behavior. Swallowed exception in camel callback will now be in our log, so we can see, what happens if error occurs.
Updated by Vít Švanda over 6 years ago
- Status changed from Closed to In Progress
Updated by Ondřej Kopr over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 60 to 90
Same behavior as project may be simulate by using FakeSMTP server locally (thanks HH) (http://nilhcem.com/FakeSMTP/), send message by approve some roles.
add two new tests, tests use fakeSMTP.
commit: https://github.com/bcvsolutions/CzechIdMng/commit/87d8739ff14b766da44e631bb1b06ac3dc5ec1ce
+ commit with test helper: https://github.com/bcvsolutions/CzechIdMng/commit/cbe36f66aa1a72e71c09f31dc5f6ccd685f4469f
Please Radek could you make a review? Thank you. This commit is already merged into hotfix 7.3.5. and develop.
Updated by Ondřej Kopr over 6 years ago
In this ticket was also created hotfix branch.
Updated by Radek Tomiška over 6 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
Notification agenda (and sending emails) works, code looks nice (i saw it before merge:)), thx.
Please add note about this asynchronous behavior to doc:
https://wiki.czechidm.com/devel/dev/notification#emailer
Updated by Ondřej Kopr over 6 years ago
Software licence compatibility MIT and BSD 3-clause “New” or “Revised” License
you can see comparsion: https://choosealicense.com/appendix/
MIT License: https://choosealicense.com/licenses/mit/
BSD 3-clause “New” or “Revised” License: https://choosealicense.com/licenses/bsd-3-clause/
Same licences are very similar. After read some articles is possible use MIT and BSD 3-clause “New” or “Revised” together. Thank you for helping all who have helped...