Actions
Task #654
closed
Refactor password policy to DTO
Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Password policy
Target version:
Start date:
08/15/2017
Due date:
% Done:
100%
Estimated time:
Owner:
Description
Refactor password policy (service, rest, entity, ...) to DTO
Updated by Ondřej Kopr over 6 years ago
- Status changed from New to Needs feedback
- Assignee changed from Ondřej Kopr to Vít Švanda
- % Done changed from 0 to 90
Implemented.
commit with transform password policy to dto: https://github.com/bcvsolutions/CzechIdMng/commit/16726b3bfc6c68849649148c28acd482679a25f4
commit with fix problem with agenda password policy connected system: https://github.com/bcvsolutions/CzechIdMng/commit/32cdcfcadd7d921f4eae94909b468f8973313bcd
Please Vitek could you make a review? Thank you.
Updated by Vít Švanda over 6 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Vít Švanda to Ondřej Kopr
- Refactoring to DTO looks and works fine.
- Outside this task I have little problem with method "isNullOrZero" (the zero value predicates turn off validation) and "compareTo".
- Please do refactoring or create comment to wiki. + merge this to develop.
Updated by Ondřej Kopr over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Vít Švanda
- remove unless excerpt,
- refactor zero values, now is this values allowed,
- merged branch into develop,
- thank you for your feedback.
commit: https://github.com/bcvsolutions/CzechIdMng/commit/522d9593e8802eb72a666976d338dc47d001fa06
Updated by Vít Švanda over 6 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Ondřej Kopr
- % Done changed from 90 to 100
I did review and test. Works fine.
Updated by Radek Tomiška over 6 years ago
- Status changed from Resolved to Closed
Actions