Project

General

Profile

Actions
Copy link

Task #605

closed

IdentityRoleExpirationTaskExecutor didn't process all

Added by Filip Měšťánek almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Scheduler
Target version:
Citrine (7.3.0)
Start date:
07/26/2017
Due date:
% Done:

100%

Estimated time:
Owner:

Description

We ran the IdentityRoleExpirationTaskExecutor task. It had 357 roles to remove in total. But it ended after 200 (so the counter was 200/357). I executed the task again and now it is running for the remaining 157. Why didn't it process all of them in the first run? There is no exception. Maybe the iteration contains some bug.

Actions
Copy link
 #1

Updated by Radek Tomiška almost 7 years ago

  • Category set to Scheduler
  • Assignee changed from Vít Švanda to Radek Tomiška
Actions
Copy link
 #2

Updated by Radek Tomiška almost 7 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Radek Tomiška to Filip Měšťánek
  • Target version set to Citrine (7.3.0)
  • % Done changed from 0 to 90

Pagination was used for searching expired roles, so when first page of expired roles was removed (100) then next search returned 57 expired roles only (=> second page and 100 expired roles was skipped) - i fix it.

Could you do a test and review pls?

Actions
Copy link
 #3

Updated by Filip Měšťánek almost 7 years ago

  • Assignee changed from Filip Měšťánek to Radek Tomiška

It works now. I also wrote a small integration test - it tests correct removing of expired role (IdentityRoleExpirationTaskExecutorIntegrationTest).

Actions
Copy link
 #4

Updated by Radek Tomiška almost 7 years ago

  • Status changed from Needs feedback to Closed
  • % Done changed from 90 to 100

Integration test is nice, thx! I've just added testHelper usage.

Actions
Copy link

Also available in: Atom PDF