Task #604
closed
MERGE strategy does not remove duplicities
100%
Description
We use MERGE strategy on LDAP roles. Provisioning queue for the user has same value of the ROLE attribute multiple times.
Merge should remove duplicities on values.
our LDAP can handle this correctly, but we cannot count on that behaviour in general. There might be and I think are systems e.g. DBs that would not handle it that well.
Updated by Vít Švanda about 7 years ago
- Target version deleted (
Diamond (7.4.0))
Updated by Marcel Poul almost 7 years ago
- Priority changed from Normal to High
Came across the situation that LDAP does not handle it.
Alena also checked CzechIdM 6 and there is remove duplicities method called on Merge.
Updated by Ondřej Kopr almost 7 years ago
- Assignee changed from Vít Švanda to Ondřej Kopr
I will implement simply check for duplicity in final list.
Updated by Ondřej Kopr almost 7 years ago
- Status changed from New to Needs feedback
- Assignee changed from Ondřej Kopr to Vít Švanda
- Priority changed from High to Normal
- % Done changed from 0 to 90
I removed duplicities by merging values. Duplicites are removed by equals with value not with role.
Please Vitek could you made a review? Thank you :)
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/d008d68a44c0f3b2942a0a97f7390e62692954e0
test are included. Test was hardest thing on this.
Updated by Ondřej Kopr almost 7 years ago
New documentation can be found there: https://wiki.czechidm.com/devel/documentation/provisioning/system-mapping#merge_merge
Updated by Vít Švanda almost 7 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Ondřej Kopr
- % Done changed from 90 to 100
I did reveiw, and works fine. Documentation and tests are nice too.