Task #481
closed
Make scheduled task editable
100%
Description
When I create a scheduled task it is not anymore possible to edit it. Make it editable, at least its description.
Implementation notes:
- BE: create new method updateTask (PUT) in SchedullerController
- BE: create new method updateTask SchedulerManager (use addJob method with the replace parameter, task identifier has to be preserved - see IdmScheduledTask.quartzTaskName)
- FE: update modal in content ScheduleTasks - remove readonly on description and parameters. Service and redux layer is prepared for update task i think.
Updated by Radek Tomiška almost 7 years ago
- Subject changed from make scheduled task editable to Make scheduled task editable
- Category set to Scheduler
- Assignee set to Radek Tomiška
- Target version set to Diamond (7.4.0)
Updated by Alena Peterová over 6 years ago
I agree with this one. It would be also nice to make editable scheduled starts.
Updated by Ondřej Kopr over 6 years ago
- Assignee changed from Radek Tomiška to Patrik Stloukal
Updated by Patrik Stloukal over 6 years ago
created method updateTask in schedulerController and manager
Updated by Patrik Stloukal over 6 years ago
work on frontend, removed readonly on description and parameters, edited save method and service
Updated by Patrik Stloukal over 6 years ago
- Status changed from New to Needs feedback
- Assignee changed from Patrik Stloukal to Ondřej Kopr
- % Done changed from 0 to 90
I did changes to save method on FE, modified updateTask on backend, tested update(edit)
please do review my implementation,
commits: https://github.com/bcvsolutions/CzechIdMng/commit/f85efba36116379985194c3d6acaa5c217ac39ea
https://github.com/bcvsolutions/CzechIdMng/commit/c8ba99654631f15702c646298b9cc339b44b98ef
Updated by Ondřej Kopr over 6 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Ondřej Kopr to Patrik Stloukal
- % Done changed from 90 to 70
I made feedback, I fund some issues:
- your new method in scheduler SchedulerController update has permission create,
- add authorizations into api operation, (basic and cidmst),
- rest url /scheduler-tasks/{taskId}/update isn't correct for update,
- @RequestBody @Valid ArrayList<Object> parametersList isn't correct you can use directly task,
- method updateTask in service and manager in FE isn't needed,
- fix permission in frontend, example: I have permission IdmScheduledTask read and update and I can't edit tasks.
Otherwise update task works well. Thank you for your new feature.
Updated by Patrik Stloukal over 6 years ago
resolved issues from feedback, problem with using Task on Rest
Updated by Patrik Stloukal over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Patrik Stloukal to Radek Tomiška
- % Done changed from 70 to 90
resolved issue with Rest, edited/changed permission to update on FE and tested in IdM.
commits: https://github.com/bcvsolutions/CzechIdMng/commit/d40855a7226c895f6ea59b9e4ed8073ba54f321e
https://github.com/bcvsolutions/CzechIdMng/commit/027c16b8ddb7dcc57e5ef924c5d598933bbf0af6
please look and review this implementation.
Updated by Radek Tomiška about 6 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Patrik Stloukal
- Target version set to Garnet (7.7.0)
- % Done changed from 90 to 100
I created instance id parameter editable too and refactor some minors (security on FE, showLoading etc).
Thx fo this new feature. It will be useful mainly for stateful tasks, where task history should remain.