Project

General

Profile

Actions
Copy link

Task #408

closed

Password change - disable password change on BE by configuration

Added by Radek Tomiška almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Rest
Target version:
Citrine (7.3.0)
Start date:
05/10/2017
Due date:
% Done:

100%

Estimated time:
4.00 h
Owner:

Description

Password change type configuration (DISABLED, ALL_ONLY) is loaded on FE only. Is needed to load configuration on BE and check this configuration on password change:
  • add PasswordChangeType enumeration to core-api domain
  • check configured type in IdentityPasswordValidateProcessor - core (disabled) and acc module (all_only).
Actions
Copy link
 #1

Updated by Ondřej Kopr almost 7 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #2

Updated by Ondřej Kopr almost 7 years ago

  • % Done changed from 0 to 90

Add new enum (PasswordChnageType) this enum has same items as application configurations. Add check if current logged user is admin.
Tested via SOAP ui.

Please Radek could you please test change password? Thank you.

Actions
Copy link
 #3

Updated by Ondřej Kopr almost 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions
Copy link
 #4

Updated by Radek Tomiška almost 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 80

I did review and found just one thing - split functionality to proccessors please:
- check password change is disabled in core IdentityPasswordValidateProcessor
- check all selected account in acc IdentityPasswordValidateProcessor and throw appropriate ex

Actions
Copy link
 #5

Updated by Ondřej Kopr almost 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 80 to 90

Logic from service is now cut to two proccesors - IdentityPasswordValidateProcessor (acc and core)
commit: https://github.com/bcvsolutions/CzechIdMng/commit/f2cda246fccd89ecfe85183efffb4069e683c48d

Actions
Copy link
 #6

Updated by Radek Tomiška almost 7 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

Its nice. I've only added new IdentityConfiguration usage and some error codes localization.

Actions
Copy link

Also available in: Atom PDF