Project

General

Profile

Actions
Copy link

Defect #3358

closed

Circular dependencies

Added by Luboš Čábelka over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Luboš Čábelka
Target version:
3.1.0
Start date:
05/09/2023
Due date:
% Done:

100%

Estimated time:
Affected versions:
3.0.0
Owner:

Description

I found circular dependencies in recertification module used on project

The dependencies of some of the beans in the application context form a cycle:

   recRecertificationManager (field private eu.bcvsolutions.idm.core.api.service.IdmRoleRequestService eu.bcvsolutions.idm.rec.service.impl.DefaultRecertificationManager.roleRequestService)
┌─────┐
|  roleRequestService defined in URL [jar:file:/srv/tomcat/apache-tomcat-9.0.46/webapps/idm/WEB-INF/lib/idm-core-impl-13.0.4.jar!/eu/bcvsolutions/idm/core/model/service/impl/DefaultIdmRoleRequestService.class]
↑     ↓
|  conceptRoleRequestService defined in URL [jar:file:/srv/tomcat/apache-tomcat-9.0.46/webapps/idm/WEB-INF/lib/idm-core-impl-13.0.4.jar!/eu/bcvsolutions/idm/core/model/service/impl/DefaultIdmConceptRoleRequestService.class]
↑     ↓
|  defaultWorkflowProcessInstanceService (field private eu.bcvsolutions.idm.core.api.service.IdmIdentityService eu.bcvsolutions.idm.core.workflow.service.impl.DefaultWorkflowProcessInstanceService.identityService)
↑     ↓
|  identityService (field private eu.bcvsolutions.idm.core.api.service.IdmRoleService eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmIdentityService.roleService)
↑     ↓
|  roleService (field private eu.bcvsolutions.idm.core.api.service.IdmRoleSystemService eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmRoleService.roleSystemService)
↑     ↓
|  defaultSysRoleSystemService (field private eu.bcvsolutions.idm.acc.service.api.SysRoleSystemAttributeService eu.bcvsolutions.idm.acc.service.impl.DefaultSysRoleSystemService.roleSystemAttributeService)
↑     ↓
|  defaultSysRoleSystemAttributeService (field private eu.bcvsolutions.idm.acc.service.api.SysSystemAttributeMappingService eu.bcvsolutions.idm.acc.service.impl.DefaultSysRoleSystemAttributeService.systemAttributeMappingService)
↑     ↓
|  defaultSysSystemAttributeMappingService (field private eu.bcvsolutions.idm.acc.service.api.AccAccountService eu.bcvsolutions.idm.acc.service.impl.DefaultSysSystemAttributeMappingService.accountService)
↑     ↓
|  accAccountService (field private java.util.List eu.bcvsolutions.idm.acc.service.impl.DefaultAccAccountService.executors)
↑     ↓
|  roleSynchronizationExecutor (field private eu.bcvsolutions.idm.core.api.service.IdmRoleRequestService eu.bcvsolutions.idm.acc.service.impl.RoleSynchronizationExecutor.roleRequestService)
└─────┘
Actions
Copy link
 #1

Updated by Luboš Čábelka over 1 year ago

  • Status changed from In Progress to Needs feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #2

Updated by Luboš Čábelka over 1 year ago

Another one:

The dependencies of some of the beans in the application context form a cycle:

   recRecertificationManager (field private eu.bcvsolutions.idm.core.api.service.IdmConceptRoleRequestManager eu.bcvsolutions.idm.rec.service.impl.DefaultRecertificationManager.conceptRoleRequestManager)
┌─────┐
|  conceptManager defined in URL [jar:file:/srv/tomcat/apache-tomcat-9.0.46/webapps/idm/WEB-INF/lib/idm-core-impl-13.0.4.jar!/eu/bcvsolutions/idm/core/model/service/impl/DefaultIdmConceptRoleRequestManager.class]
↑     ↓
|  accountConceptRoleService defined in URL [jar:file:/srv/tomcat/apache-tomcat-9.0.46/webapps/idm/WEB-INF/lib/idm-acc-13.0.4.jar!/eu/bcvsolutions/idm/acc/service/impl/DefaultAccAccountConceptRoleRequestService.class]
↑     ↓
|  defaultWorkflowProcessInstanceService (field private eu.bcvsolutions.idm.core.api.service.IdmIdentityService eu.bcvsolutions.idm.core.workflow.service.impl.DefaultWorkflowProcessInstanceService.identityService)
↑     ↓
|  identityService (field private eu.bcvsolutions.idm.core.api.service.IdmRoleService eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmIdentityService.roleService)
↑     ↓
|  roleService (field private eu.bcvsolutions.idm.core.api.service.IdmRoleSystemService eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmRoleService.roleSystemService)
↑     ↓
|  defaultSysRoleSystemService (field private eu.bcvsolutions.idm.acc.service.api.SysRoleSystemAttributeService eu.bcvsolutions.idm.acc.service.impl.DefaultSysRoleSystemService.roleSystemAttributeService)
↑     ↓
|  defaultSysRoleSystemAttributeService (field private eu.bcvsolutions.idm.acc.service.api.SysSystemAttributeMappingService eu.bcvsolutions.idm.acc.service.impl.DefaultSysRoleSystemAttributeService.systemAttributeMappingService)
↑     ↓
|  defaultSysSystemAttributeMappingService (field private eu.bcvsolutions.idm.acc.service.api.AccAccountService eu.bcvsolutions.idm.acc.service.impl.DefaultSysSystemAttributeMappingService.accountService)
↑     ↓
|  accAccountService (field private java.util.List eu.bcvsolutions.idm.acc.service.impl.DefaultAccAccountService.executors)
↑     ↓
|  roleSynchronizationExecutor (field private eu.bcvsolutions.idm.core.api.service.IdmRoleRequestService eu.bcvsolutions.idm.acc.service.impl.RoleSynchronizationExecutor.roleRequestService)
↑     ↓
|  roleRequestService (field private eu.bcvsolutions.idm.core.api.service.IdmConceptRoleRequestManager eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmRoleRequestService.conceptRoleRequestManager)
└─────┘
Actions
Copy link
 #3

Updated by Peter Štrunc over 1 year ago

  • Status changed from Needs feedback to Closed

LGTM, merged, released.

Actions
Copy link

Also available in: Atom PDF