Project

General

Profile

Actions
Copy link

Task #332

closed

Create long running tasks for automatic roles and use new request role api

Added by Radek Tomiška about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Roles
Target version:
Citrine (7.3.0)
Start date:
03/20/2017
Due date:
% Done:

100%

Estimated time:
10.00 h
Owner:

Description

Integrate new role request api to automatic roles processors:
  • IdentityContractCreateByAutomaticRoleProcessor - assing roles by automatic roles configuration.
  • IdentityContractUpdateByAutomaticRoleProcessor - change assined roles by automatic roles configuration.
  • RoleTreeNodeSaveProcessor - creates new automatic role and assing role to all contract by work position
  • RoleTreeNodeDeleteProcessor - removes all assigned roles by deleted automatic role configuration
Create two long running tasks - move functionality from two processors to long running task:

Related issues

Related to IdStory Identity Manager - Task #347: IdentityRole - unmodifiable automatic roleClosedOndřej Kopr03/29/2017

Actions
Actions
Copy link
 #1

Updated by Ondřej Kopr about 7 years ago

  • % Done changed from 0 to 20
Update
  • IdentityContractCreateByAutomaticRoleProcessor
  • IdentityContractUpdateByAutomaticRoleProcessor - add create request and concepts, only same thing is change relation only.
Actions
Copy link
 #2

Updated by Ondřej Kopr about 7 years ago

  • Related to Task #347: IdentityRole - unmodifiable automatic role added
Actions
Copy link
 #3

Updated by Ondřej Kopr about 7 years ago

  • Status changed from New to In Progress
  • % Done changed from 20 to 60
Actions
Copy link
 #4

Updated by Ondřej Kopr about 7 years ago

  • % Done changed from 60 to 90
Update:
  • RoleTreeNodeDeleteProcessor,
  • RoleTreeNodeSaveProcessor is not necessary to update. Call method assignAutomaticRoles that create request with concept,
  • create two new methods in IdmRoleTreeNodeService (create, updateOrRemove automatic roles).

Create long running task:
AddNewAutomaticRoleTaskExecutor and RemoveAutomaticRoleTaskExecutor, update test - wait for long running task

Thank you Radek for great test for automatic roles, they are awesome, help me some much.

Actions
Copy link
 #5

Updated by Ondřej Kopr about 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška

Please Radek could you make me code review? Thank you.

Actions
Copy link
 #6

Updated by Ondřej Kopr about 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
Actions
Copy link
 #7

Updated by Ondřej Kopr about 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška

I repaired problem with jenkins and wait for long running task, thank you Radek for help.

Actions
Copy link
 #8

Updated by Radek Tomiška about 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
I did test and review, i works nice, i found some minor issues:
  • IdentityContractUpdateByAutomaticRoleProcessor - RoleRequest could be created, if it is needed to (when automatic role reference is chenged only, then request should not be created)
  • ConceptRoleRequestOperation - javadoc is missing. Id needed in updateOrRemoveAutomaticRoles - its called from only one place as remove?
  • use RoleTreeNode id as input parametr to long running tasks
  • Whole long running task runs under one transaction, it could be problematic, but leave it rigtht now, as it is .)
Actions
Copy link
 #9

Updated by Ondřej Kopr about 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Thank you for feedback:
  • IdentityContractUpdateByAutomaticRoleProcessor - i was added new method for save and check role request, now is role request save only when i need,
  • add javadoc for ConceptRoleRequestOperation, method updateOrRemoveAutomaticRoles was renamed and updated parameters,
  • remove RoleTreeNode from long runnign task and replace with UUID.

Thank you for check my code.

Actions
Copy link
 #10

Updated by Radek Tomiška about 7 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

Its nice, thx .) I would prefer to prepare whole RoleRequest and save them at the end, if contains at least one ConceptRole, but its ok (its about style and my opinion only).

Actions
Copy link

Also available in: Atom PDF